Uh oh!
There was an error while loading. Please reload this page.
Better Identifier Emission & State Handling - #891
Merged
Conversation
HurricanKai
commented
Apr 18, 2022
MemberAuthor
Nevermind. I figured out why this was happening & the fix - I don't understand roslyn sometimes. |
HurricanKai
enabled auto-merge (squash)
April 18, 2022 22:31
Perksey
approved these changes
Apr 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that tests are indeed failing, but this is due to an oddity in roslyn that means Identifiers are created with trivia. Investigating but I'd like to merge this, ignoring the failing tests. I think it's worth tracking this oddity, but not worth blocking on.