Skip to content

[7.0] Changed SBOM package version to use build number - #4120

Closed
paulmedynski wants to merge 1 commit into
cherry-pick/7.0/4077from
cherry-pick/7.0/4095
Closed

paulmedynski wants to merge 1 commit into
cherry-pick/7.0/4077from
cherry-pick/7.0/4095

Conversation

@paulmedynski

Copy link
Copy Markdown
Contributor

Cherry-pick of #4095 to release/7.0


Original PR Description

Description

OneBranch doesn't provide a way to specify per-job SBOM parameters, so we can't use our actual package names and versions. Instead, we must specify a single SBOM name and version that applies to all packages the pipeline creates. The build number is unique enough for this purpose.

Testing

The normal scheduled OneBranch Non-Official runs will confirm.

Copilot AI review requested due to automatic review settings March 31, 2026 19:32
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Mar 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the OneBranch Official and Non-Official pipeline SBOM configuration to use the Azure DevOps build number as the single SBOM package version, since OneBranch SBOM settings are global (not per-job) and need a unique value that applies across all produced packages.

Changes:

  • Switched globalSdl.sbom.packageVersion from $(mdsPackageVersion) to $(Build.BuildNumber) in the official OneBranch pipeline.
  • Switched globalSdl.sbom.packageVersion from $(mdsPackageVersion) to $(Build.BuildNumber) in the non-official OneBranch pipeline.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/pipelines/onebranch/sqlclient-official.yml Uses $(Build.BuildNumber) for the global SBOM packageVersion in the official OneBranch pipeline.
eng/pipelines/onebranch/sqlclient-non-official.yml Uses $(Build.BuildNumber) for the global SBOM packageVersion in the non-official OneBranch pipeline.

@paulmedynski paulmedynski added this to the 7.0.1 milestone Mar 31, 2026
@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Mar 31, 2026
@paulmedynski
paulmedynski marked this pull request as ready for review March 31, 2026 19:49
@paulmedynski
paulmedynski requested a review from a team as a code owner March 31, 2026 19:49
@paulmedynski
paulmedynski marked this pull request as draft April 2, 2026 15:47
@paulmedynski paulmedynski modified the milestones: 7.0.1, 7.0.2 Apr 6, 2026
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Apr 21, 2026
@paulmedynski
paulmedynski deleted the cherry-pick/7.0/4095 branch April 21, 2026 16:54
@cheenamalhotra cheenamalhotra removed this from the 7.0.2 milestone Apr 21, 2026
@paulmedynski paulmedynski modified the milestone: 7.0.2 Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants