Remove platform-specific builds

src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/ISniNativeMethods.cs

@@ -1,9 +1,7 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#if _WINDOWS
-
 using System;
 using System.Runtime.InteropServices;
 using System.Text;
@@ -101,5 +99,3 @@ unsafe uint SniSecGenClientContextWrapper(
         uint SniWriteSyncOverAsync(SNIHandle pConn, SNIPacket pPacket);
     }
 }
-
-#endif

src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeMethods.netcore.cs

@@ -1,8 +1,8 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#if NET && _WINDOWS
+#if NET
 
 using System;
 using System.Runtime.InteropServices;

src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeMethodsArm64.netfx.cs

@@ -1,8 +1,8 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#if NETFRAMEWORK && _WINDOWS
+#if NETFRAMEWORK
 
 using System;
 using System.Runtime.InteropServices;

src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeMethodsNotSupported.netfx.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#if NETFRAMEWORK && _WINDOWS
+#if NETFRAMEWORK
 
 using System;
 using System.Runtime.InteropServices;

src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeMethodsX64.netfx.cs

@@ -1,8 +1,8 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#if NETFRAMEWORK && _WINDOWS
+#if NETFRAMEWORK
 
 using System;
 using System.Runtime.InteropServices;

src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeMethodsX86.netfx.cs

@@ -1,8 +1,8 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#if NETFRAMEWORK && _WINDOWS
+#if NETFRAMEWORK
 
 using System;
 using System.Runtime.InteropServices;

src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeWrapper.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
- #if _WINDOWS
-
 using System;
 using System.Buffers;
 using System.Diagnostics;
@@ -452,5 +450,3 @@ private static void MarshalConsumerInfo(ConsumerInfo consumerInfo, ref SniConsum
         #endregion
     }
 }
-
-#endif

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

@@ -19,11 +19,6 @@
     <!--<TargetOs>Windows_NT</TargetOs>-->
 
     <NormalizedTargetOs>$(TargetOs.ToLower())</NormalizedTargetOs>
-
-    <!-- NOTE: These constants are prefixed with _ to keep them separate from .NET 5+ precompiler -->
-    <!--     flags. Those only apply to OS-specific target frameworks, and would interfere here.  -->
-    <DefineConstants Condition="'$(NormalizedTargetOs)' == 'unix'">$(DefineConstants);_UNIX</DefineConstants>
-    <DefineConstants Condition="'$(NormalizedTargetOs)' == 'windows_nt'">$(DefineConstants);_WINDOWS</DefineConstants>
   </PropertyGroup>
 
   <!-- Target Frameworks =============================================== -->
@@ -231,11 +226,11 @@
   <!-- Embedded resources ============================================== -->
   <ItemGroup>
     <!-- Linker directives to replace UseManagedNetworking with a constant if consumer specifies  -->
-    <!-- the app context switch in their csproj. This file only applies to netcore on windows.    -->
+    <!-- the app context switch in their csproj. This file only applies to netcore.               -->
     <!-- This file does not support pre-processor directives, so it must be conditionally         -->
     <!-- included into the build.                                                                 -->
     <EmbeddedResource Include="Resources\ILLink.Substitutions.xml"
-                      Condition="'$(NormalizedTargetOs)' == 'windows_nt' AND '$(TargetFramework)' != 'net462'">
+                      Condition="'$(TargetFramework)' != 'net462'">
       <LogicalName>ILLink.Substitutions.xml</LogicalName>
     </EmbeddedResource>
 

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumerator.cs

@@ -27,16 +27,10 @@ public override DataTable GetDataSources()
             #if NETFRAMEWORK
             return SqlDataSourceEnumeratorNativeHelper.GetDataSources();
             #else
-
-            #if _UNIX
-            return SqlDataSourceEnumeratorManagedHelper.GetDataSources();
-            #else
             return SqlClient.LocalAppContextSwitches.UseManagedNetworking
                 ? SqlDataSourceEnumeratorManagedHelper.GetDataSources()
                 : SqlDataSourceEnumeratorNativeHelper.GetDataSources();
             #endif
-
-            #endif
         }
     }
 }

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumeratorNativeHelper.windows.cs → src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumeratorNativeHelper.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#if _WINDOWS
-
 using System;
 using System.Data;
 using System.Diagnostics;
@@ -175,5 +173,3 @@ private static DataTable ParseServerEnumString(string serverInstances)
         }
     }
 }
-
-#endif

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPoolIdentity.cs

@@ -54,19 +54,9 @@ public override int GetHashCode()
 
         internal static DbConnectionPoolIdentity GetCurrent()
         {
-            #if NETFRAMEWORK
-            return GetCurrentNative();
-            #else
-
-            #if _UNIX
-            return GetCurrentManaged();
-            #else
             return LocalAppContextSwitches.UseManagedNetworking
                 ? GetCurrentManaged()
                 : GetCurrentNative();
-            #endif
-
-            #endif
         }
 
         #if NETFRAMEWORK
@@ -94,7 +84,6 @@ private static DbConnectionPoolIdentity GetCurrentManaged()
             return current;
         }
 
-        #if _WINDOWS
         private static DbConnectionPoolIdentity GetCurrentNative()
         {
             DbConnectionPoolIdentity current;
@@ -124,7 +113,6 @@ private static DbConnectionPoolIdentity GetCurrentNative()
             s_lastIdentity = current;
             return current;
         }
-        #endif
     }
 }
 

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/LocalDb/LocalDbApi.windows.cs → src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/LocalDb/LocalDbApi.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#if _WINDOWS
-
 using System;
 using System.Diagnostics;
 using System.Globalization;
@@ -276,7 +274,12 @@ internal static void DemandLocalDbPermissions()
         // localDB can also have a format of np:\\.\pipe\LOCALDB#<some number>\tsql\query
         internal static string GetLocalDbInstanceNameFromServerName(string serverName)
         {
-            if (serverName is not null)
+            // LocalDB is only supported on Windows
+            if (!OsConstants.IsWindows)
+            {
+                return null;
+            }
+            else if (serverName is not null)
             {
                 // it can start with spaces if specified in quotes
                 // Memory allocation is reduced by using ReadOnlySpan
@@ -300,6 +303,12 @@ internal static string GetLocalDbInstanceNameFromServerName(string serverName)
 
         internal static string GetLocalDbMessage(int hrCode)
         {
+            if (!OsConstants.IsWindows)
+            {
+                // LocalDB is not available for Unix and hence it cannot be supported.
+                throw new PlatformNotSupportedException(Strings.LocalDBNotSupported);
+            }
+
             Debug.Assert(hrCode < 0, "HRCode does not indicate error");
             try
             {
@@ -422,5 +431,3 @@ internal InstanceInfo(string version)
         #endif
     }
 }
-
-#endif

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/PacketHandle.netcore.windows.cs → src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/PacketHandle.netcore.cs

@@ -3,7 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 // @TODO: Introduce polymorphism to remove need for this level of indirection
-#if NET && _WINDOWS
+#if NET
 
 using System;
 
@@ -18,7 +18,6 @@ namespace Microsoft.Data.SqlClient
     /// </summary>
     /// <remarks>
     /// It is a ref struct so that it can only be used to transport the handles and not store them.
-    /// If you change this type you must also change the version for the other platform.
     /// </remarks>
     internal readonly ref struct PacketHandle
     {

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SSPI/NativeSspiContextProvider.windows.cs → src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SSPI/NativeSspiContextProvider.cs

@@ -1,9 +1,7 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#if _WINDOWS
-
 using System;
 using System.Buffers;
 using System.Diagnostics;
@@ -85,5 +83,3 @@ protected override bool GenerateContext(ReadOnlySpan<byte> incomingBlob, IBuffer
         }
     }
 }
-
-#endif

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SessionHandle.netcore.windows.cs → src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SessionHandle.netcore.cs

@@ -3,7 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 // @TODO: Merge with other implementations (and/or introduce polymorphism to handle this indirection)
-#if NET && _WINDOWS
+#if NET
 
 namespace Microsoft.Data.SqlClient
 {
@@ -15,7 +15,6 @@ namespace Microsoft.Data.SqlClient
     /// </summary>
     /// <remarks>
     /// It is a ref struct so that it can only be used to transport the handles and not store them.
-    /// If you change this type you must also change the version for the other platform.
     /// </remarks>
     internal readonly ref struct SessionHandle
     {