Skip to content

[Release/2.0] Fix | Fix Enclave Session Cache Issue with Azure Database - #628

Merged
cheenamalhotra merged 12 commits into
dotnet:2.0-servicingfrom
karinazhou:EnclaveSessionCache2.0
Jul 21, 2020
Merged

[Release/2.0] Fix | Fix Enclave Session Cache Issue with Azure Database#628
cheenamalhotra merged 12 commits into
dotnet:2.0-servicingfrom
karinazhou:EnclaveSessionCache2.0

Conversation

@karinazhou

@karinazhoukarinazhou commented Jun 26, 2020

Copy link
Copy Markdown
Member

This PR is to fix the issue when connecting to Azure SQL databases with secure enclaves.

The initial enclave session cache key only contains the enclave attestation URL and the server name. It works well with on-prem SQL Servers if we switch between various databases under the same server. However, this will fail for Azure SQL. Sharing the same enclave session among different databases under the same logic Azure server will cause the Azure attestation to fail.

To fix this issue, the database name is also added to the enclave session cache key.

@cheenamalhotracheenamalhotra changed the title Fix | Fix Enclave Session Cache Issue wit Azure DatabaseFix | Fix Enclave Session Cache Issue with Azure DatabaseJul 6, 2020
@cheenamalhotra

cheenamalhotra commented Jul 6, 2020

Copy link
Copy Markdown
Member

cc @Xtrimmer

cheenamalhotra
cheenamalhotra reviewed Jul 6, 2020
View reviewed changes
Comment threaddoc/snippets/Microsoft.Data.SqlClient/SqlColumnEncryptionEnclaveProvider.xml Outdated
Comment threaddoc/snippets/Microsoft.Data.SqlClient/SqlColumnEncryptionEnclaveProvider.xml Outdated
Comment threadsrc/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/EnclaveDelegate.NetCoreApp.cs Outdated
Comment thread...Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/EnclaveDelegate.NetStandard.cs Outdated
Comment thread...Client/netcore/src/Microsoft/Data/SqlClient/SqlColumnEncryptionEnclaveProvider.NetCoreApp.cs Outdated
Comment threadsrc/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SimulatorEnclaveProvider.cs Outdated
Comment threadsrc/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/EnclaveAzureDatabaseTests.cs Outdated
Comment threadsrc/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/EnclaveAzureDatabaseTests.cs Outdated
Comment threadsrc/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/EnclaveAzureDatabaseTests.cs
Comment threadsrc/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Outdated
@cheenamalhotracheenamalhotra added this to the 2.0.1 milestone Jul 7, 2020
karinazhouand others added 7 commits July 7, 2020 14:23
@karinazhou@cheenamalhotra
Update src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlCli…
56962e8
…ent/SqlColumnEncryptionEnclaveProvider.NetCoreApp.cs
Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
@karinazhou@cheenamalhotra
Update src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClien…
53232f2
…t/SimulatorEnclaveProvider.cs
Extended parameter description
Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
@karinazhou@cheenamalhotra
Update src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlCli…
06bfae3
…ent/EnclaveDelegate.NetStandard.cs
Extended parameter description
Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
@karinazhou@cheenamalhotra
Update src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlCli…
500d0ad
…ent/EnclaveDelegate.NetCoreApp.cs
Updated parameter description
Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
@karinazhou@cheenamalhotra
Update doc/snippets/Microsoft.Data.SqlClient/SqlColumnEncryptionEncla…
8e1b95f
…veProvider.xml
Updated parameter description
Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
@karinazhou@cheenamalhotra
Update doc/snippets/Microsoft.Data.SqlClient/SqlColumnEncryptionEncla…
ea7a4a8
…veProvider.xml
Updated parameter description
Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
@karinazhou
Change based on eview comments
fd2ab49
Xtrimmer
Xtrimmer reviewed Jul 8, 2020
View reviewed changes
Comment threadsrc/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/EnclaveSessionCache.cs Outdated
@cheenamalhotracheenamalhotra changed the title Fix | Fix Enclave Session Cache Issue with Azure Database[Release/2.0] Fix | Fix Enclave Session Cache Issue with Azure DatabaseJul 8, 2020
cheenamalhotra
cheenamalhotra reviewed Jul 14, 2020
View reviewed changes
Comment threaddoc/snippets/Microsoft.Data.SqlClient/SqlColumnEncryptionEnclaveProvider.xml Outdated
Comment threadsrc/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/EnclaveDelegate.NetCoreApp.cs Outdated
Comment thread...t.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SimulatorEnclaveProvider.NetCoreApp.cs Outdated
Comment threadsrc/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/EnclaveDelegate.cs Outdated
/// <param name="enclaveType">enclave type</param>
/// <param name="serverName">server name</param>
/// <param name="enclaveAttestationUrl">url for attestation endpoint</param>
/// <param name="database">The database that SqlClient contacts to.</param>

@cheenamalhotracheenamalhotraJul 14, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Pending]

Comment threadsrc/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/EnclaveDelegate.cs Outdated
/// <param name="enclaveType">enclave type</param>
/// <param name="serverName">servername</param>
/// <param name="attestationUrl">attestation url for attestation service endpoint</param>
/// <param name="database">The database that SqlClient contacts to.</param>

@cheenamalhotracheenamalhotraJul 14, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Pending]

@cheenamalhotra
cheenamalhotra merged commit 0c80751 into dotnet:2.0-servicingJul 21, 2020
@karinazhoukarinazhou mentioned this pull request Aug 12, 2020
Merged
@dependabotdependabotBot mentioned this pull request Jul 23, 2025
Open
@dependabotdependabotBot mentioned this pull request Dec 30, 2025
Merged
@dependabotdependabotBot mentioned this pull request Jun 1, 2026
Open
@dependabotdependabotBot mentioned this pull request Aug 11, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotracheenamalhotracheenamalhotra approved these changes
+4 more reviewers
@ErikEJErikEJErikEJ left review comments
@XtrimmerXtrimmerXtrimmer approved these changes
@johnnyphamjohnnyphamjohnnypham approved these changes
@JRahnamaJRahnamaJRahnama approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.1

Development

Successfully merging this pull request may close these issues.

6 participants

@karinazhou@cheenamalhotra@Xtrimmer@ErikEJ@johnnypham@JRahnama