Uh oh!
There was an error while loading. Please reload this page.
Rename netcore string resource file and helpers - #671
Merged
Conversation
Wraith2force-pushed
the
merge-renamestrings
branch
from
July 29, 2020 19:36
f7b136a to
b8eacaeCompareDavid-Engel
approved these changes
Jul 29, 2020
Wraith2
commented
Aug 7, 2020
ContributorAuthor
Is there any chance of getting this merged to unblock further merge pr's? |
cheenamalhotra
approved these changes
Aug 7, 2020
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the resources and helper file into sync between netcore and netfx by using the netfx naming scheme. This may allow localization in netcore in future.
/cc @cheenamalhotra@David-Engel