Skip to content

Remove duplicate CacheConnectionStringProperties calls - #683

Merged
cheenamalhotra merged 1 commit into
dotnet:masterfrom
karinazhou:Fix_CacheConnectionStringProperties
Aug 20, 2020
Merged

Remove duplicate CacheConnectionStringProperties calls#683
cheenamalhotra merged 1 commit into
dotnet:masterfrom
karinazhou:Fix_CacheConnectionStringProperties

Conversation

@karinazhou

@karinazhoukarinazhou commented Aug 10, 2020

Copy link
Copy Markdown
Member

According to #680, we have some unnecessary CacheConnectionStringProperties calls after setting ConnectionString properties.

@cheenamalhotracheenamalhotra added this to the 2.1.0-preview1 milestone Aug 13, 2020
@cheenamalhotracheenamalhotra linked an issue Aug 17, 2020 that may be closed by this pull request
CacheConnectionStringProperties is called twice when initializing SqlConnection. #680
Closed
DavoudEshtehari
DavoudEshtehari reviewed Aug 17, 2020
View reviewed changes
Comment threadsrc/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs
Comment threadsrc/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
@cheenamalhotracheenamalhotra added the Performance 📈 Issues that are targeted to performance improvements. label Aug 18, 2020
@cheenamalhotra
cheenamalhotra merged commit f0e90e2 into dotnet:masterAug 20, 2020
TrayanZapryanov pushed a commit to TrayanZapryanov/SqlClient that referenced this pull request Aug 31, 2020
@karinazhou@TrayanZapryanov
Remove duplicate CacheConnectionStringProperties calls (dotnet#683)
4ae7ee9
TrayanZapryanov added a commit to TrayanZapryanov/SqlClient that referenced this pull request Aug 31, 2020
@TrayanZapryanov
Revert "Remove duplicate CacheConnectionStringProperties calls (dotne…
14fa64f
…t#683)"
This reverts commit 4ae7ee9.
@karinazhou
karinazhou deleted the Fix_CacheConnectionStringProperties branch December 14, 2020 19:49
@dependabotdependabotBot mentioned this pull request Jul 23, 2025
Open
@dependabotdependabotBot mentioned this pull request Dec 30, 2025
Merged
@dependabotdependabotBot mentioned this pull request Feb 26, 2026
Closed
This was referenced May 22, 2026
Open
Open
@dependabotdependabotBot mentioned this pull request Jun 1, 2026
Open
This was referenced Aug 11, 2026
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotracheenamalhotracheenamalhotra approved these changes
+2 more reviewers
@johnnyphamjohnnyphamjohnnypham approved these changes
@DavoudEshtehariDavoudEshtehariDavoudEshtehari approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Performance 📈Issues that are targeted to performance improvements.

Projects

None yet

Milestone

2.1.0-preview1

Development

Successfully merging this pull request may close these issues.

CacheConnectionStringProperties is called twice when initializing SqlConnection.

4 participants

@karinazhou@cheenamalhotra@johnnypham@DavoudEshtehari