Uh oh!
There was an error while loading. Please reload this page.
Merge some metadata classes - #753
Conversation
cheenamalhotra
commented
Oct 8, 2020
Just FYI.. |
cheenamalhotra
commented
Oct 8, 2020
The pipelines are back, could you try pushing an update to your PR? |
Wraith2
commented
Oct 9, 2020
I looked at the Close implementation and originally pulled it into the netcore version but later tracing through what it did I realised it was totally dead code and re-removed it. So I did the due diligence even though it looks like I just took netcore. Pipelines seem to be passed now... |
cheenamalhotra
commented
Oct 9, 2020
Yep I got that, just wanted to call out changes in case that raises questions. |
Wraith2
commented
Oct 9, 2020
turned it off and then turned it on again, that triggered it 😁 |
Wraith2
commented
Oct 12, 2020
The test failures are from a changed localized message that's being tested for directly. That seems a bit fragile and it isn't related to the changes that I've made in this PR. |
JRahnama
commented
Oct 19, 2020
LGTM. |
Another small set of merges. No noteworthy changes.