Uh oh!
There was an error while loading. Please reload this page.
Document LoggingPermission constructor - #460
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the API XML documentation for Java.Util.Logging.LoggingPermission to reflect the Java SE contract for the LoggingPermission(String, String) constructor, replacing “To be added.” placeholders with concrete parameter and summary text.
Changes:
- Documented the required
namevalue (control) for the constructor. - Documented the allowed
actionsvalues (nullor empty string). - Added a concise constructor
<summary>.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jonathanpeppers
commented
Aug 15, 2026
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
docs/xml/Java.Util.Logging/LoggingPermission.xml: the constructor documents the accepted values but omits its enforced failure behavior. A null name throws Java.Lang.NullPointerException, while an empty/invalid name or invalid actions throw Java.Lang.IllegalArgumentException. Please document both exceptions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bcaa47e-a2e3-4285-a2e4-630247d650b1
jonathanpeppers
commented
Aug 18, 2026
Addressed the requested constructor failure behavior in 6ba4e58: documented Java.Lang.NullPointerException for a null |
dalexsoto
left a comment
There was a problem hiding this comment.
The new constructor contract contradicts supported Android behavior. Android's LoggingPermission constructor ignores both arguments and calls super("", ""), so null/invalid names and arbitrary actions are accepted; the nullable managed signature reflects this. Please document that Android ignores the arguments and remove the unsupported exception claims.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bcaa47e-a2e3-4285-a2e4-630247d650b1
jonathanpeppers
commented
Aug 18, 2026
Addressed the Android-specific behavior in 5a4c415. Both constructor parameters now say "Ignored on Android," and the unsupported exception claims were removed. |
dalexsoto
left a comment
There was a problem hiding this comment.
The LoggingPermission constructor now accurately documents Android's ignored arguments and nullable managed signature.
Uh oh!
There was an error while loading. Please reload this page.
Refs #251
Documents the Java SE
LoggingPermission(String, String)contract while leaving generated interop placeholders and unverified members out of scope.Sources
Validation
docs/xml/Java.Util.Logging/*.xmlfile as XML.git diff --checkand reviewed the focused namespace diff.