Skip to content

Document Android.Telephony.Ims namespace - #540

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-telephony-ims-xml-docs
Aug 18, 2026
Merged

Document Android.Telephony.Ims namespace#540
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-telephony-ims-xml-docs

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

  • Replaced the Android.Telephony.Ims namespace placeholder with a description of its IMS service and MMTEL/RCS manager APIs.

Refs #196

Sources

Validation

  • Parsed docs/xml/ns-Android.Telephony.Ims.xml as XML.
  • Confirmed CRLF line endings, no remaining To be added placeholder, and a clean git diff --check.

Refs #196
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CopilotAI lite review requested due to automatic review settings August 15, 2026 14:36
@jonathanpeppers

Copy link
Copy Markdown
MemberAuthor

@dalexsoto Please review this narrow AOSP-backed namespace documentation update.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the namespace-level XML documentation for Android.Telephony.Ims to replace the placeholder text with a short description of the IMS-related API surface.

Changes:

  • Replaced the To be added. placeholder summary/remarks with an IMS-focused namespace description.
  • Documented that the namespace includes MMTEL and RCS manager APIs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jonathanpeppers

Copy link
Copy Markdown
MemberAuthor

@dalexsoto review

1 similar comment
@jonathanpeppers

Copy link
Copy Markdown
MemberAuthor

@dalexsoto review

@dalexsotodalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace summary says the managed surface supports implementing IMS services, but this namespace exposes no public ImsService; Android's implementation type is hidden/system API and is not part of the generated .NET namespace. Please remove the implementation claim or restrict it to the separate feature/stub surfaces that are actually available: ns-Android.Telephony.Ims.xml.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9832b94e-5a7a-4f20-9d9e-668f41a0245c
@jonathanpeppers

Copy link
Copy Markdown
MemberAuthor

Addressed the review in a06d3bd by removing the unsupported implementation claim. The namespace summary now describes only access to IMS services; the separate feature/stub namespace documentation remains unchanged.

@dalexsotodalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IMS namespace documentation now accurately describes only the available services and manager surface without unsupported implementation claims.

@jonathanpeppers
jonathanpeppers merged commit 1e33414 into mainAug 18, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-telephony-ims-xml-docs branch August 18, 2026 21:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanpeppers@dalexsoto