Document MatrixCursor RowBuilder APIs

[jonathanpeppers]

Summary

• Documents the MatrixCursor.RowBuilder.Add overload parameter, return, and behavior descriptions.

Sources

• Android MatrixCursor.RowBuilder reference
• AOSP MatrixCursor.java

Validation

• Parsed docs/xml/Android.Database/MatrixCursor+RowBuilder.xml with PowerShell's XML parser.
• Confirmed CRLF line endings and ran git diff --check.

Refs #87

[Copilot]

Pull request overview

This PR updates the XML documentation for Android.Database.MatrixCursor.RowBuilder to replace placeholder text with concrete parameter/return descriptions aligned with the Android reference docs.

Changes:

• Documented the Add(Object columnValue) overload’s parameter meaning and chaining return value.
• Documented the Add(string columnName, Object value) overload’s parameters, chaining return value, and “offer-if-column-exists” behavior in the summary.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[jonathanpeppers]

@dalexsoto review

[dalexsoto]

RowBuilder.Add(string? columnName, object? value) accepts a nullable managed name, but Android dereferences it and throws NullPointerException for null; the new wording instead implies unmatched names are merely ignored. Please document the non-null requirement and exception contract, and consider correcting the binding nullability: MatrixCursor+RowBuilder.xml.

[jonathanpeppers]

@dalexsoto Addressed in 0d09543: Add(string columnName, ...) now has a non-null managed signature, its parameter documentation requires a non-null name, and its NullPointerException contract is documented. The unmatched-column behavior remains documented separately.

[dalexsoto]

The nullability fix is incomplete:

• The displayed string columnName signature no longer matches the shipping managed API, which remains string? across current monikers. Either restore string? or fix binding metadata upstream and regenerate.
• A null name does not always throw: a valid zero-column cursor skips the dereference and returns normally. Keep the non-null precondition, but remove or qualify the unconditional NullPointerException claim.

[jonathanpeppers]

Addressed the latest review on the refreshed branch: restored the shipping \string? columnName\ signature, retained the non-null precondition in the parameter documentation, and removed the unconditional \NullPointerException\ claim because zero-column cursors do not dereference the name.

[dalexsoto]

The RowBuilder contract now preserves the shipping nullable signature while accurately documenting name matching and zero-column behavior.