Uh oh!
There was an error while loading. Please reload this page.
Document Java logging binding members - #576
Conversation
Refs #251 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the generated XML documentation for the Java.Util.Logging namespace, replacing placeholder text and improving member documentation consistency with existing JNI binding doc patterns across the repo.
Changes:
- Replaces
To be added.placeholders forJniPeerMembersproperty docs across multipleJava.Util.Loggingtypes. - Documents
LoggingPermission(string name, string actions)parameters and constructor summary.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/xml/Java.Util.Logging/XMLFormatter.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/StreamHandler.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/SocketHandler.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/SimpleFormatter.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/MemoryHandler.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/LogRecord.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/LogManager.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/LoggingPermission.xml | Documents ctor parameters/summary and replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/Logger.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/Level.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/Handler.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/Formatter.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/FileHandler.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/ErrorManager.xml | Replaces placeholder JniPeerMembers docs. |
| docs/xml/Java.Util.Logging/ConsoleHandler.xml | Replaces placeholder JniPeerMembers docs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Refs #251 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
commented
Aug 16, 2026
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
LoggingPermission documents Java SE constructor restrictions but omits their NullPointerException/IllegalArgumentException behavior, while Android's implementation is a legacy stub that ignores both arguments. Please choose and document one complete authoritative contract rather than the current inconsistent hybrid: LoggingPermission.xml.
Refs #251 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
commented
Aug 17, 2026
@dalexsoto Addressed the requested change in 61879d5. The constructor documentation now describes the Android/AOSP contract: both supplied arguments are ignored and the base permission is initialized with empty name and actions values. The PR Sources section now links the Android reference and AOSP implementation. |
dalexsoto
left a comment
There was a problem hiding this comment.
The docs now consistently choose Android's stub behavior, but they claim both observable Name and Actions are always empty. On supported API 21–23 both are null, and on API 24–26 Name remains null; both become empty only from API 27. Please state only that constructor arguments are ignored, or document the API-specific observable values.
Sources
LoggingPermissionreferenceLoggingPermissionimplementationdocs/xml/Java.Nio.Channels.Spi/SelectorProvider.xmlValidation
docs/xml/Java.Util.Logging/*.xmlfiles as XML.To be added.placeholders inJava.Util.Logging(excludingdocs/xml/index.xml).git diff --check.Refs #251