Uh oh!
There was an error while loading. Please reload this page.
Document Org.Apache.Http.Client.Params - #585
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fills in XML documentation for types in the Org.Apache.Http.Client.Params namespace (addressing the “To be added.” placeholders noted in #279) by adding summaries/params/returns and standard Android/AOSP attribution content.
Changes:
- Replaced placeholder summaries/params/returns with concrete documentation across
AuthPolicy,CookiePolicy,ClientParamBean, andHttpClientParams. - Documented
IClientPNamesand its parameter-name constants, including an Android reference link and attribution. - Updated
JniPeerMembersdocumentation to match the established infrastructure wording/value pattern.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/xml/Org.Apache.Http.Client.Params/IClientPNames.xml | Adds type/member docs and Android/AOSP attribution for client parameter name constants. |
| docs/xml/Org.Apache.Http.Client.Params/HttpClientParams.xml | Documents key parameter accessors/mutators (params/returns) and infrastructure properties. |
| docs/xml/Org.Apache.Http.Client.Params/CookiePolicy.xml | Replaces placeholder summary and infrastructure property docs. |
| docs/xml/Org.Apache.Http.Client.Params/ClientParamBean.xml | Documents constructor and configuration methods; replaces placeholders. |
| docs/xml/Org.Apache.Http.Client.Params/AuthPolicy.xml | Replaces placeholder summary and infrastructure property docs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
commented
Aug 16, 2026
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
Two blockers remain in IClientPNames:
- The eleven raw string keys omit the runtime value types consumed through untyped
IHttpParams, andConnectionManagerFactoryClassNameincorrectly describes a connection-manager class rather than a factory class. - Each field publishes independently but has empty remarks, so the type-level AOSP/CC attribution is not inherited.
Please document each key's expected value type, correct the factory description, and add member-level attribution.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 12608efb-a04a-416a-b69e-9428779f04ab
Closes#279
Sources
AuthPolicy.java,CookiePolicy.java,ClientPNames.java,ClientParamBean.java, andHttpClientParams.java.Validation
docs/xml/Org.Apache.Http.Client.Params/*.xmlfile as XML.To be addedplaceholders and preserves CRLF line endings.git diff --check.