Uh oh!
There was an error while loading. Please reload this page.
Document Org.Apache.Http.Client.Protocol - #586
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR replaces placeholder XML documentation (“To be added.”) across Org.Apache.Http.Client.Protocol with API-specific docs covering HTTP context keys, context configuration helpers, request/response interceptors, and JNI peer metadata entries.
Changes:
- Added namespace/type/member summaries and remarks for the
Org.Apache.Http.Client.ProtocolXML docs (removing placeholders). - Documented HTTP context attribute keys (
IClientContextandClientContextConfigurer.InterfaceConsts) and context configuration (ClientContextConfigurer). - Documented interceptor types and their purpose (e.g., target/proxy authentication interceptors) and filled in JNI-related member docs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/xml/Org.Apache.Http.Client.Protocol/ResponseProcessCookies.xml | Replaces placeholder docs; updates JNI peer member documentation. |
| docs/xml/Org.Apache.Http.Client.Protocol/RequestTargetAuthentication.xml | Adds interceptor summary; updates JNI peer member documentation. |
| docs/xml/Org.Apache.Http.Client.Protocol/RequestProxyAuthentication.xml | Adds interceptor summary; updates JNI peer member documentation. |
| docs/xml/Org.Apache.Http.Client.Protocol/RequestDefaultHeaders.xml | Updates JNI peer member documentation. |
| docs/xml/Org.Apache.Http.Client.Protocol/RequestAddCookies.xml | Updates JNI peer member documentation. |
| docs/xml/Org.Apache.Http.Client.Protocol/IClientContext.xml | Documents context attribute constants and adds obsolescence/remar ks content. |
| docs/xml/Org.Apache.Http.Client.Protocol/ClientContextConfigurer+InterfaceConsts.xml | Documents inherited context attribute names (consts). |
| docs/xml/Org.Apache.Http.Client.Protocol/ClientContextConfigurer.xml | Documents context configurer type and members; updates JNI peer member documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
commented
Aug 16, 2026
@dalexsoto review |
1 similar comment
jonathanpeppers
commented
Aug 18, 2026
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
Two protocol documentation gaps remain:
ClientContextConfigurerhas a nullable managed constructor parameter, but AOSP rejects null withJava.Lang.IllegalArgumentException; document the non-null requirement and exception.- The public compatibility
ClientContexttype still has blank summaries for all ten constants while equivalentIClientContextandInterfaceConstsmembers are documented.
Please add the constructor contract and keep the compatibility projection in parity.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0794cefb-ece4-45f7-ac33-4b4cf05a5cad
jonathanpeppers
commented
Aug 18, 2026
Addressed in 9ea4350: the configurer constructor now documents its non-null contract and |
dalexsoto
left a comment
There was a problem hiding this comment.
The configurer null contract and all ClientContext compatibility constants now match the Apache implementation and managed projections.
Uh oh!
There was an error while loading. Please reload this page.
Summary
To be added.entries underOrg.Apache.Http.Client.Protocolwith API-specific documentation.Closes#265
Sources
Validation
docs/xml/Org.Apache.Http.Client.Protocol/*.xmlfile as XML.To be added.placeholders in the scoped XML files.git diff --check.