Skip to content

Document JsonReader token values - #587

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-android-util-docs
Aug 18, 2026
Merged

Document JsonReader token values#587
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-android-util-docs

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Refs #247

Sources

Validation

  • XML parsed with PowerShell [xml].
  • Confirmed CRLF-only line endings with zero lone LF characters.
  • Ran git diff --check.

Documented DocIds: P:Android.Util.JsonReader.HasNext, M:Android.Util.JsonReader.NextBoolean, M:Android.Util.JsonReader.NextDouble, M:Android.Util.JsonReader.NextInt, M:Android.Util.JsonReader.NextLong, M:Android.Util.JsonReader.NextName, M:Android.Util.JsonReader.NextString, and M:Android.Util.JsonReader.Peek.

Refs #247
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the XML documentation for Android.Util.JsonReader by replacing “To be added.” placeholders with concrete <value>/<returns> descriptions, aligning the docs more closely with the upstream Android reference documentation.

Changes:

  • Documented HasNext property value semantics (true/false meaning).
  • Added concrete <returns> documentation for NextBoolean, NextDouble, NextInt, NextLong, NextName, NextString, and Peek.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment threaddocs/xml/Android.Util/JsonReader.xml Outdated
Refs #247
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
MemberAuthor

@dalexsoto review

1 similar comment
@jonathanpeppers

Copy link
Copy Markdown
MemberAuthor

@dalexsoto review

@dalexsotodalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JsonReader token consumption, coercion, return values, exceptions, and managed signatures match Android.

@jonathanpeppers
jonathanpeppers merged commit 20f621d into mainAug 18, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-android-util-docs branch August 18, 2026 17:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanpeppers@dalexsoto