Uh oh!
There was an error while loading. Please reload this page.
Document Java.Time Instant APIs - #590
Conversation
Refs #276 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Java.Time.Instant XML documentation to replace remaining placeholders and align member docs with Android reference content for java.time.Instant.
Changes:
- Replaced large blocks of “To be added.” placeholders with summaries, parameter/return descriptions, and remarks for many
Instantmembers. - Added Android reference links and attribution notices throughout the type and member documentation.
- Refined remarks for key properties/methods (e.g.,
Now,OfEpochSecond,ToEpochMilli, truncation/field queries).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
commented
Aug 16, 2026
@dalexsoto review |
1 similar comment
jonathanpeppers
commented
Aug 18, 2026
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
Three Instant documentation defects remain:
With(ITemporalAdjuster)includes scraped licensing/footer and “Last updated” text inside the member contract.- Both Boolean
IsSupportedoverloads omit their required return-value documentation. Parse(ICharSequence)labels its parameter asstring, contradicting the managedJava.Lang.ICharSequencesignature.
Please remove the footer, restore both return contracts, and use the correct CharSequence/ICharSequence parameter type.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 309835a7-2ea3-4822-b124-a5b713796f13
jonathanpeppers
commented
Aug 18, 2026
Addressed the remaining review feedback in 34356d7: removed the scraped footer from |
dalexsoto
left a comment
There was a problem hiding this comment.
The Instant contracts now have correct return documentation, parameter types, source content, ranges, and generated metadata.
Uh oh!
There was an error while loading. Please reload this page.
Refs #276
Sources
Validation