Uh oh!
There was an error while loading. Please reload this page.
Document Media Session playback flags - #613
Conversation
Refs #137 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR improves the generated XML documentation for Android.Media.Session by replacing a few remaining “To be added.” placeholders with meaningful summaries/values, focusing on media session playback flags, playback types, and MediaController.Extras.
Changes:
- Documented
MediaSessionFlagsmembers for media button handling and transport controls. - Documented
MediaPlaybackTypevalues for local vs. remote playback. - Replaced the placeholder
<value>text forMediaController.Extras.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/xml/Android.Media.Session/MediaSessionFlags.xml | Replaces placeholder summaries for public media-session handling flags. |
| docs/xml/Android.Media.Session/MediaPlaybackType.xml | Replaces placeholder summaries for local/remote playback type values. |
| docs/xml/Android.Media.Session/MediaController.xml | Replaces placeholder value text for MediaController.Extras. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Refs #137 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
commented
Aug 16, 2026
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
Two media-session blockers remain:
PlaybackInfo.PlaybackTypeis mapped toAndroid.Media.MediaPlaybackType(0/1) although Android returns session playback values1/2; local values appear as remote and remote values are unnamed. Please correct the binding toAndroid.Media.Session.MediaPlaybackTypeand regenerate.- Both
MediaSessionFlagsmembers are deprecated no-ops since API 26, but their summaries describe active behavior and enum-field remarks are not published. Put the no-op/deprecation guidance directly in the summaries or generate matching obsolescence metadata.
Correct PlaybackInfo.PlaybackType to use the session playback enum and document that the legacy session flags are no-ops starting with API 26. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
commented
Aug 18, 2026
Addressed both blockers in bbb40d0:
Validated XML parsing, generated-page type/signature compatibility, CRLF line endings, and git diff --check. |
dalexsoto
left a comment
There was a problem hiding this comment.
PlaybackInfo.PlaybackType is documented as Android.Media.Session.MediaPlaybackType, but the shipping managed reference assembly still exposes Android.Media.MediaPlaybackType. The new published signature therefore would not compile for consumers. Please correct the binding upstream and regenerate this file, or retain the actual managed signature until that binding change ships.
Retain the generated PlaybackInfo.PlaybackType metadata from the shipping managed reference assembly until the upstream binding correction ships. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: af23b1a9-3cb5-4a1d-ad0b-bddd4be609e5
jonathanpeppers
commented
Aug 18, 2026
Resolved the new compatibility concern in 361dde7. MediaController.PlaybackInfo.PlaybackType now retains the generated Android.Media.MediaPlaybackType signature from the shipping managed reference assembly; the upstream binding correction is not being simulated in this docs-only PR. Revalidated XML parsing, generated-page compatibility with the shipping signature, CRLF, and git diff --check. |
dalexsoto
left a comment
There was a problem hiding this comment.
The docs now preserve the shipping managed playback-type signature while accurately documenting values, nullable extras, and API 26 flag behavior.
Uh oh!
There was an error while loading. Please reload this page.
Summary
MediaController.Extras, local and remote playback types, and the public media-session handling flags.Refs #137
Sources
Validation
git diff --check.Android.Media.Sessionplaceholders from 273 to 268.