Skip to content

Document Animation callbacks - #634

Open
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-view-animation-apis-8a6
Open

Document Animation callbacks#634
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-view-animation-apis-8a6

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

  • Documents Animation lifecycle callbacks plus values for animation duration, background color, and wallpaper detachment.

Refs #244

Sources

Validation

  • XML parsed successfully with PowerShell [xml].
  • Confirmed CRLF-only line endings and a trailing CRLF.
  • Reduced Android.Views.AnimationsTo be added placeholders from 110 to 104; Animation.xml retains only the two .NET infrastructure JniPeerMembers placeholders.
  • git diff --check passed.

Refs #244
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the API reference XML documentation for Android.Views.Animations.Animation by replacing several remaining placeholder docs with meaningful descriptions, focusing on animation lifecycle callbacks and a few related properties/methods.

Changes:

  • Documented AnimationStart, AnimationRepeat, and AnimationEnd event summaries.
  • Replaced placeholder <value> documentation for BackgroundColor and DetachWallpaper.
  • Replaced placeholder <returns> documentation for ComputeDurationHint().

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment threaddocs/xml/Android.Views.Animations/Animation.xml Outdated
Comment threaddocs/xml/Android.Views.Animations/Animation.xml Outdated
Refs #244
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
MemberAuthor

@dalexsoto review

@dalexsotodalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AnimationEnd says the event is never raised for infinite-repeat animations, but a started infinite animation does raise it when Animation.Cancel() invokes fireAnimationEnd(). Please qualify the statement as applying to natural completion or explicitly document cancellation.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanpeppers@dalexsoto