Skip to content

Document Android Window splash screen - #638

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-android-window-apis
Aug 18, 2026
Merged

Document Android Window splash screen#638
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-android-window-apis

Conversation

@jonathanpeppers

@jonathanpeppersjonathanpeppers commented Aug 17, 2026

Copy link
Copy Markdown
Member

Refs #194

Sources

Validation

  • XML parse: passed (docs/xml/Android.Window/SplashScreen.xml)
  • CRLF line endings: passed
  • Diff check: passed (git diff --check)
  • Source anchor: passed (Android SplashScreen reference)
  • Scoped placeholders: passed (0 in the updated type docs)

@jonathanpeppers
Document Android Window splash screen
2172c9c
Refs #194
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers requested review from dalexsoto and a lite review from CopilotAugust 17, 2026 13:31
@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) August 17, 2026 13:31
CopilotAI reviewed Aug 17, 2026

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jonathanpeppers

jonathanpeppers commented Aug 17, 2026

Copy link
Copy Markdown
MemberAuthor

@dalexsoto review

dalexsoto
dalexsoto requested changes Aug 18, 2026
View reviewed changes

@dalexsotodalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SplashScreen.xml directs users to Activity.GetSplashScreen(), which does not exist in the managed API. The binding exposes Activity.SplashScreen returning Android.Window.ISplashScreen, so the published guidance would not compile. Please reference the property, preferably with <see cref="P:Android.App.Activity.SplashScreen"/>.

@jonathanpeppers
Fix splash screen activity reference
e14ac64
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3ec1b0d-533a-4ff9-95aa-c68e41df8dba
@jonathanpeppers

jonathanpeppers commented Aug 18, 2026

Copy link
Copy Markdown
MemberAuthor

Addressed the review feedback in e14ac64: the guidance now references the managed Activity.SplashScreen property via <see cref="P:Android.App.Activity.SplashScreen" />.

dalexsoto
dalexsoto approved these changes Aug 18, 2026
View reviewed changes

@dalexsotodalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SplashScreen guidance now references the valid managed Activity.SplashScreen property and generates correctly.

@jonathanpeppers
jonathanpeppers merged commit 0ebe83a into mainAug 18, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-document-android-window-apis branch August 18, 2026 19:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dalexsotodalexsotodalexsoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanpeppers@dalexsoto