Uh oh!
There was an error while loading. Please reload this page.
Document JDBC connection properties - #640
Conversation
Refs #189 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
commented
Aug 17, 2026
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
Two property contracts need correction:
TransactionIsolationconflates getter and setter domains. The getter may returnTransactionNone, but assigningTRANSACTION_NONEis invalid and must throwSQLException; distinguish readable results from setter-valid values.HoldabilityandTransactionIsolationuse Java identifiers such asResultSet.HOLD_CURSORS_OVER_COMMITandConnection.TRANSACTION_READ_COMMITTED, which do not exist in the managed API. Replace them with managed references such asIResultSet.HoldCursorsOverCommitandIConnection.TransactionReadCommitted.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f7bb4d04-d38f-491b-bca9-805acbe0ccf3
jonathanpeppers
commented
Aug 18, 2026
Addressed the review in 910fc74: |
dalexsoto
left a comment
There was a problem hiding this comment.
The previously reported constant and setter-domain issues are fixed, but two managed-contract problems remain:
TypeMapstill names Java'sjava.util.Mapinstead of the exposed managedIDictionary<string, Java.Lang.Class>type.- The five transaction-isolation
altmemberlinks nearTransactionIsolationtarget obsoleteJava.Sql.Connectionconstants that direct users toIConnection.
Please use the managed type/cref and point all related constants to Java.Sql.IConnection.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f7bb4d04-d38f-491b-bca9-805acbe0ccf3
jonathanpeppers
commented
Aug 18, 2026
Addressed the remaining managed-contract feedback in dabfc95: |
dalexsoto
left a comment
There was a problem hiding this comment.
The managed TypeMap type and transaction constant links are fixed, but the TypeMap contract still implies the returned dictionary is directly associated with the connection. JDBC requires callers to assign the map back after modification because drivers may retain an internal copy. Please document that reassignment/setter requirement and link the setter source alongside the getter.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f7bb4d04-d38f-491b-bca9-805acbe0ccf3
jonathanpeppers
commented
Aug 18, 2026
Addressed the latest |
dalexsoto
left a comment
There was a problem hiding this comment.
The TypeMap reassignment contract is fixed, but the metadata property now names Java's DatabaseMetaData, which does not exist in the managed API. The generated signature returns Java.Sql.IDatabaseMetaData?; please reference the managed interface, preferably with <see cref="T:Java.Sql.IDatabaseMetaData" />.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f7bb4d04-d38f-491b-bca9-805acbe0ccf3
jonathanpeppers
commented
Aug 18, 2026
Addressed the metadata feedback in f7e5efd: the |
dalexsoto
left a comment
There was a problem hiding this comment.
All JDBC property contracts now use valid managed types and constants, including TypeMap reassignment and IDatabaseMetaData.
Uh oh!
There was an error while loading. Please reload this page.
Sources
Validation
docs/xml/Java.Sql/IConnection.xmlTo be added.placeholder validation forIConnectiongit diff --check@dalexsoto please review this focused JDBC connection property documentation update.