Skip to content

[build] Add 'net6.0-android30.0' TargetFramework. - #340

Merged
jpobst merged 1 commit into
mainfrom
multi-target
Jul 28, 2021
Merged

[build] Add 'net6.0-android30.0' TargetFramework.#340
jpobst merged 1 commit into
mainfrom
multi-target

Conversation

@jpobst

@jpobstjpobst commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Add net6.0-android30.0 assemblies to AndroidX NuGets.

@@ -7,3 +7,4 @@
[assembly: AssemblyMetadata ("BUILD_TIMESTAMP", "{BUILD_TIMESTAMP}")]

[assembly: Android.LinkerSafe]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[assembly: LinkerSafe] will be a warning in .NET 6:

https://github.com/xamarin/xamarin-android/blob/e4debf72015549e6e19cbfb247a47fead6ce7a01/src/Mono.Android/Android/LinkerSafeAttribute.cs#L5-L7

You could #if around it for .NET 6. But there are probably so many warnings, probably not seeing it anyway.

@jpobstjpobstJul 27, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think that warning isn't showing up yet since [LinkerSafe] won't be [Obsolete] until P7.

Wrapped it in #if !NETCOREAPP.

@jpobst
jpobst marked this pull request as ready for review July 27, 2021 22:04
@jpobst
jpobst requested a review from moljacJuly 27, 2021 22:05

@moljacmoljac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@jpobst
jpobst merged commit 4d0e013 into mainJul 28, 2021
@jpobst
jpobst deleted the multi-target branch July 28, 2021 15:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jpobst@jonathanpeppers@moljac