Bind important missing compose stable packages by 4brunu · Pull Request #441 · dotnet/android-libraries

4brunu · 2021-12-09T11:41:13Z

~~This PR depends on #436 and can only be merged after it.~~

This PR is a continuation of #419

Support Libraries Version (eg: 23.3.0):

Compose bindings that are essential to bind native android libraries that use jetpack compose.

- androidx.activity:activitycompose - -> 1.4.0
- androidx.compose.ui:uitooling - -> 1.1.1
- androidx.compose.ui:uitoolingpreview - -> 1.1.1
- androidx.compose.ui:uitoolingdata - -> 1.1.1
- androidx.lifecycle:lifecycleviewmodelcompose - -> 2.4.0
- com.google.android.material:composethemeadapter - -> 1.0.0
- io.github.aakira:napier - -> 1.4.1
- com.google.accompanist:accompanistappcompattheme - -> 0.16.0
- com.google.accompanist:accompanistdrawablepainter - -> 0.16.0
- com.google.accompanist:accompanistflowlayout - -> 0.16.0
- com.google.accompanist:accompanistpager - -> 0.16.0
- com.google.accompanist:accompanistpagerindicators - -> 0.16.0
- com.google.accompanist:accompanistpermissions - -> 0.16.0
- com.google.accompanist:accompanistplaceholder - -> 0.16.0
- com.google.accompanist:accompanistplaceholdermaterial - -> 0.16.0
- com.google.accompanist:accompanistswiperefresh - -> 0.16.0
- com.google.accompanist:accompanistsystemuicontroller - -> 0.16.0
- androidx.activity:activityktx - -> 1.3.0
- androidx.lifecycle:lifecycleviewmodelktx - -> 2.3.0
- androidx.compose.ui:ui - -> 1.0.0

Does this change any of the generated binding API's?

No.

Describe your contribution

Those bindings are important to bind native android libraries that use jetpack compose, since they are very commonly used.

#352 introduced initial support for Jetpack Compse.

But there are some important missing packages.

For example, without androidx.activity:activity-compose it's not possible to call compose from an Activity, hence, it's not possible to use compose at all.

Without androidx.compose.ui:ui-tooling* it's not possible to use one of the best features of compose that are previews.

Without com.google.android.material:compose-theme-adapter and com.google.accompanist:accompanist-appcompat-theme it's not possible to reuse the existing theme from Views in the compose world.

And there are more packages in the com.google.accompanist:*, that are extensions to compose that make compose much more powerful and easy to use.

4brunu · 2022-03-15T17:36:08Z

Hey @moljac, could you please help to review and merge this PR? Thanks

moljac · 2022-03-15T18:48:10Z

/azp run

azure-pipelines · 2022-03-15T18:48:21Z

Azure Pipelines successfully started running 1 pipeline(s).

4brunu · 2022-03-17T08:46:46Z

@moljac Did it fail? Could you please share the errors? Thanks

moljac · 2022-03-17T10:53:36Z

========================================
binderate
========================================
Unhandled exception. System.Net.Http.HttpRequestException: Response status code does not indicate success: 404 (Not Found).
at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
at System.Net.Http.HttpClient.GetStreamAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
at MavenNet.GoogleMavenRepository.GetArtifactsAsync(String groupId)
at MavenNet.MavenRepository.GetArtifactsAsync(String groupId, String[] artifactIds)
at MavenNet.MavenRepository.Populate(String groupId, String[] artifactIds)
at AndroidBinderator.MavenFactory.Initialize(BindingConfig config) in D:\a\1\s\Util\Xamarin.AndroidBinderator\Xamarin.AndroidBinderator\MavenFactory.cs:line 33
at AndroidBinderator.Engine.BinderateAsync(BindingConfig config) in D:\a\1\s\Util\Xamarin.AndroidBinderator\Xamarin.AndroidBinderator\Engine.cs:line 37
at Xamarin.AndroidBinderator.Tool.Program.Main(String[] args) in D:\a\1\s\Util\Xamarin.AndroidBinderator\Xamarin.AndroidBinderator.Tool\Program.cs:line 67
at Xamarin.AndroidBinderator.Tool.Program.<Main>(String[] args)
An error occurred when executing task 'binderate'.
Error: One or more errors occurred. (Process xamarin-android-binderator exited with code 57005.)
Process xamarin-android-binderator exited with code 57005.

4brunu · 2022-03-21T10:42:21Z

@moljac Thanks for the help.
Is there any more info related which artifact cannot be found?
Is there any way for me to test this locally?
Thanks

moljac · 2022-03-21T18:47:44Z

 {
"groupId": "io.github.aakira",
"artifactId": "napier",
"version": "1.4.1",
"nugetVersion": "1.4.1",
"nugetId": "Xamarin.AAkira.Napier",
"dependencyOnly": false
},

https://github.com/4brunu/XamarinAndroidX/blob/feature/more-compose-stable-packages/config.json#L1539-L1546

not google maven repo

https://repo1.maven.org/maven2/io/github/aakira/napier/1.4.1/

4brunu · 2022-03-23T12:46:33Z

Thanks for helping to fix the issue.
Do you know why it's still failing?

moljac · 2022-03-23T13:05:06Z

Thanks for helping to fix the issue.

NP.

Do you know why it's still failing?

Partially. A lot of dependencies are exact/strict dependencies in form [1.0.1] and for new artifacts you skipped versions causing errors. Yes binderator does not report those and I am adding some logging info for the future use. (I work on new tooling, but have not enough time to continue).

We'll need few rounds of updates for this one and I'll need your help after I untangle all mess.

4brunu · 2022-03-23T13:07:10Z

Thanks, do you prefer if I split this big PR into smaller ones?
Or should I leave it like this?

moljac · 2022-07-22T11:21:05Z

/azp run

azure-pipelines · 2022-07-22T11:21:19Z

Azure Pipelines failed to run 1 pipeline(s).

moljac · 2022-07-26T10:58:09Z

error

Dependency errors : 1
1
System.Exception: No matching artifact config found for: androidx.activity.activity-ktx:[1.4.0]
to satisfy dependency of: androidx.activity.activity-compose:1.4.0
Please add following json snippet to config.json:
{
"groupId": "androidx.activity",
"artifactId": "activity-ktx",
"version": "[1.4.0]",
"nugetVersion": "CHECK PREFIX [1.4.0]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}

4brunu · 2022-07-26T11:09:06Z

@moljac the androidx.activity:activity-ktx was present but it was duplicated.
I removed the duplication in c8df489.
Maybe this was the issue?
Let's see if CI passes.

4brunu · 2022-07-26T11:23:24Z

CI is still failing.
@moljac could you please check what the error is now?
Thanks

4brunu · 2022-07-26T11:33:32Z

+ {
+ "groupId": "com.google.guava",
+ "artifactId": "failureaccess",
+ "version": "1.0.1",
+ "nugetVersion": "1.0.1.5",
+ "nugetId": "Xamarin.Google.Guava.FailureAccess",
+ "dependencyOnly": true
+ },
+ {
+ "groupId": "com.google.guava",
+ "artifactId": "guava",
+ "version": "29.0.0",
+ "nugetVersion": "29.0.0",
+ "nugetId": "Xamarin.Google.Guava",
+ "dependencyOnly": true
+ },
+ {
+ "groupId": "com.google.guava",
+ "artifactId": "listenablefuture",
+ "version": "1.0",
+ "nugetVersion": "1.0.0.5",
+ "nugetId": "Xamarin.Google.Guava.ListenableFuture",
+ "dependencyOnly": true
+ },
+ {
+ "groupId": "androidx.lifecycle",
+ "artifactId": "lifecycle-viewmodel-ktx",
+ "version": "2.3.0",
+ "nugetVersion": "2.3.1.3",
+ "nugetId": "Xamarin.AndroidX.Lifecycle.ViewModel.Ktx",
+ "dependencyOnly": true
+ },
+ {
+ "groupId": "androidx.compose.ui",
+ "artifactId": "ui",
+ "version": "1.0.0",
+ "nugetVersion": "1.0.0",
+ "nugetId": "Xamarin.AndroidX.Compose.UI",
+ "dependencyOnly": true
+ },


@moljac all of those are duplicated in config.json.
Is this a bug?
First they are declare with dependencyOnly to false, and then to true.

I think those are duplicated, so I remove them here d99ef0a

….com/4brunu/XamarinAndroidX into pr/441

moljac · 2022-08-06T12:20:14Z

ups

neverending story


5
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel-ktx:[2.5.0]
to satisfy dependency of: androidx.lifecycle.lifecycle-viewmodel-compose:2.5.0
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel-ktx",
"version": "[2.5.0]",
"nugetVersion": "CHECK PREFIX [2.5.0]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
6
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel-savedstate:[2.5.0]
to satisfy dependency of: androidx.lifecycle.lifecycle-viewmodel-compose:2.5.0
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel-savedstate",
"version": "[2.5.0]",
"nugetVersion": "CHECK PREFIX [2.5.0]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}

hopefully last change

moljac · 2022-08-06T15:52:53Z

OMG another round

Dependency errors : 23
1
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel-savedstate:2.5.1
to satisfy dependency of: androidx.activity.activity:1.5.1
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel-savedstate",
"version": "2.5.1",
"nugetVersion": "CHECK PREFIX 2.5.1",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
2
System.Exception: No matching artifact config found for: androidx.activity.activity:[1.5.0]
to satisfy dependency of: androidx.activity.activity-ktx:1.5.0
Please add following json snippet to config.json:
{
"groupId": "androidx.activity",
"artifactId": "activity",
"version": "[1.5.0]",
"nugetVersion": "CHECK PREFIX [1.5.0]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
3
System.Exception: Artifact
androidx.compose.animation.animation-core:1.2.0
has unknown 'Runtime' dependency androidx.compose.ui.ui:1.2.0
Either fulfill or exclude this dependency.
4
System.Exception: No matching artifact config found for: androidx.compose.ui.ui:1.2.0
to satisfy dependency of: androidx.compose.foundation.foundation:1.2.0
Please add following json snippet to config.json:
{
"groupId": "androidx.compose.ui",
"artifactId": "ui",
"version": "1.2.0",
"nugetVersion": "CHECK PREFIX 1.2.0",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
5
System.Exception: No matching artifact config found for: androidx.compose.ui.ui:1.2.0
to satisfy dependency of: androidx.compose.foundation.foundation-layout:1.2.0
Please add following json snippet to config.json:
{
"groupId": "androidx.compose.ui",
"artifactId": "ui",
"version": "1.2.0",
"nugetVersion": "CHECK PREFIX 1.2.0",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
6
System.Exception: No matching artifact config found for: androidx.compose.ui.ui:1.2.0
to satisfy dependency of: androidx.compose.material.material:1.2.0
Please add following json snippet to config.json:
{
"groupId": "androidx.compose.ui",
"artifactId": "ui",
"version": "1.2.0",
"nugetVersion": "CHECK PREFIX 1.2.0",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
7
System.Exception: No matching artifact config found for: androidx.compose.ui.ui-geometry:[1.1.1]
to satisfy dependency of: androidx.compose.ui.ui:1.1.1
Please add following json snippet to config.json:
{
"groupId": "androidx.compose.ui",
"artifactId": "ui-geometry",
"version": "[1.1.1]",
"nugetVersion": "CHECK PREFIX [1.1.1]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
8
System.Exception: No matching artifact config found for: androidx.compose.ui.ui-graphics:[1.1.1]
to satisfy dependency of: androidx.compose.ui.ui:1.1.1
Please add following json snippet to config.json:
{
"groupId": "androidx.compose.ui",
"artifactId": "ui-graphics",
"version": "[1.1.1]",
"nugetVersion": "CHECK PREFIX [1.1.1]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
9
System.Exception: No matching artifact config found for: androidx.compose.ui.ui-text:[1.1.1]
to satisfy dependency of: androidx.compose.ui.ui:1.1.1
Please add following json snippet to config.json:
{
"groupId": "androidx.compose.ui",
"artifactId": "ui-text",
"version": "[1.1.1]",
"nugetVersion": "CHECK PREFIX [1.1.1]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
10
System.Exception: No matching artifact config found for: androidx.compose.ui.ui-unit:[1.1.1]
to satisfy dependency of: androidx.compose.ui.ui:1.1.1
Please add following json snippet to config.json:
{
"groupId": "androidx.compose.ui",
"artifactId": "ui-unit",
"version": "[1.1.1]",
"nugetVersion": "CHECK PREFIX [1.1.1]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
11
System.Exception: Artifact
androidx.compose.ui.ui:1.1.1
has unknown 'Runtime' dependency androidx.compose.ui.ui-util:[1.1.1]
Either fulfill or exclude this dependency.
12
System.Exception: Artifact
androidx.compose.ui.ui-viewbinding:1.2.0
has unknown 'Runtime' dependency androidx.compose.ui.ui:[1.2.0]
Either fulfill or exclude this dependency.
13
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel-savedstate:2.5.1
to satisfy dependency of: androidx.fragment.fragment:1.5.1
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel-savedstate",
"version": "2.5.1",
"nugetVersion": "CHECK PREFIX 2.5.1",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
14
System.Exception: No matching artifact config found for: androidx.activity.activity-ktx:1.5.1
to satisfy dependency of: androidx.fragment.fragment-ktx:1.5.1
Please add following json snippet to config.json:
{
"groupId": "androidx.activity",
"artifactId": "activity-ktx",
"version": "1.5.1",
"nugetVersion": "CHECK PREFIX 1.5.1",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
15
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel-ktx:2.5.1
to satisfy dependency of: androidx.fragment.fragment-ktx:1.5.1
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel-ktx",
"version": "2.5.1",
"nugetVersion": "CHECK PREFIX 2.5.1",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
16
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-common:[2.5.0]
to satisfy dependency of: androidx.lifecycle.lifecycle-common-java8:2.5.0
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-common",
"version": "[2.5.0]",
"nugetVersion": "CHECK PREFIX [2.5.0]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
17
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel:[2.5.0]
to satisfy dependency of: androidx.lifecycle.lifecycle-viewmodel-ktx:2.5.0
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel",
"version": "[2.5.0]",
"nugetVersion": "CHECK PREFIX [2.5.0]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
18
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-livedata-core:[2.5.0]
to satisfy dependency of: androidx.lifecycle.lifecycle-viewmodel-savedstate:2.5.0
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-livedata-core",
"version": "[2.5.0]",
"nugetVersion": "CHECK PREFIX [2.5.0]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
19
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel:[2.5.0]
to satisfy dependency of: androidx.lifecycle.lifecycle-viewmodel-savedstate:2.5.0
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel",
"version": "[2.5.0]",
"nugetVersion": "CHECK PREFIX [2.5.0]",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
20
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel-ktx:2.5.1
to satisfy dependency of: androidx.navigation.navigation-common:2.5.1
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel-ktx",
"version": "2.5.1",
"nugetVersion": "CHECK PREFIX 2.5.1",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
21
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel-savedstate:2.5.1
to satisfy dependency of: androidx.navigation.navigation-common:2.5.1
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel-savedstate",
"version": "2.5.1",
"nugetVersion": "CHECK PREFIX 2.5.1",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
22
System.Exception: No matching artifact config found for: androidx.activity.activity-ktx:1.5.1
to satisfy dependency of: androidx.navigation.navigation-runtime:2.5.1
Please add following json snippet to config.json:
{
"groupId": "androidx.activity",
"artifactId": "activity-ktx",
"version": "1.5.1",
"nugetVersion": "CHECK PREFIX 1.5.1",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}
23
System.Exception: No matching artifact config found for: androidx.lifecycle.lifecycle-viewmodel-ktx:2.5.1
to satisfy dependency of: androidx.navigation.navigation-runtime:2.5.1
Please add following json snippet to config.json:
{
"groupId": "androidx.lifecycle",
"artifactId": "lifecycle-viewmodel-ktx",
"version": "2.5.1",
"nugetVersion": "CHECK PREFIX 2.5.1",
"nugetId": "CHECK NUGET ID",
"dependencyOnly": true/false
}

4brunu · 2022-08-06T20:53:18Z

@moljac thank you so much for you effort in merging this PR, this is a very important step for the future of android development 👍

moljac · 2022-08-06T20:57:18Z

@moljac thank you so much for you effort in merging this PR, this is a very important step for the future of android development 👍

sorry for not being reviewed and merged earlier. There was tons of other stuff with higher priorities, then some blocking stuff, etc...

BTW if you can create some samples and show me/us, so we can integrate those into tests - that would be great

4brunu added 4 commits November 2, 2021 11:38

Create more compose packages
cba824f

Add new words to dictionary
f73ea95

Merge branch 'main' into feature/more-compose-stable-packages
7cf714a

Create more compose packages
3b517f9

4brunu changed the title ~~Bind important missing compose stable packages [DEPENDS ON OTHER PR]~~Bind important missing compose stable packagesJan 31, 2022

4brunu added 4 commits February 2, 2022 15:27

bind Xamarin.AndroidX.Lifecycle.ViewModel.Compose
25547af

Merge branch 'main' into feature/more-compose-stable-packages
46e73f4

Merge branch 'main' into feature/more-compose-stable-packages
f804eda

Merge branch 'main' into feature/more-compose-stable-packages
8e3c006

napier dependency as template set
b881cfb

moljac added 10 commits March 24, 2022 14:20

binderate green setup
5ac7f62

new accompanist template
8988886

TFM
53389d4

TFM
11d7199

legal stuff added
6fb1a8c

removed JavaDocJar
34747b1

legal files
2f1f87e

cleanup (moved to source)
ea0558a

MonoAndroid12.0
a127eda

Merge branch 'main' into feature/more-compose-stable-packages
ccba5a0

moljac added 4 commits July 22, 2022 09:13

Update NuGet.config
1d4c491

Update Directory.Packages.AX.props
62703cd

net6 xamarin.forms (android only)
48f0004

Merge branch 'main' into feature/more-compose-stable-packages
c3149ae

moljac added 2 commits July 22, 2022 13:35

xcode merge cleanup
e4a66b2

Merge branch 'main' into feature/more-compose-stable-packages
e8f7431

remove duplicated Xamarin.AndroidX.Activity.Ktx
c8df489

4brunu commented Jul 26, 2022
View reviewed changes

4brunuand others added 10 commits July 26, 2022 16:14

Remove duplicated dependencies
d99ef0a

Update packages
3ddccd3

XamarinDotNetWorkloadSource updated
ad84428

Create workloads.json
73cf9ac

samples reworked
bb5e9de

Merge branch 'feature/more-compose-stable-packages' ofhttps://github…
01445a1
….com/4brunu/XamarinAndroidX into pr/441

Merge branch 'main' into feature/more-compose-stable-packages
be316f1

Xamarin.Google.Guava.ListenableFuture 9999.0.0
88f6680

Update NuGet.config
1a285ad

Merge branch 'main' into feature/more-compose-stable-packages
a14cbef

fixes after merge
d0510ec

moljac merged commit f6549ae into dotnet:mainAug 6, 2022

4brunu deleted the feature/more-compose-stable-packages branch August 8, 2022 09:58

Uh oh!

Conversation

4brunu commented Dec 9, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Support Libraries Version (eg: 23.3.0):

Does this change any of the generated binding API's?

Describe your contribution

Uh oh!

4brunu commented Mar 15, 2022

Uh oh!

moljac commented Mar 15, 2022

Uh oh!

azure-pipelinesBot commented Mar 15, 2022

Uh oh!

4brunu commented Mar 17, 2022

Uh oh!

moljac commented Mar 17, 2022

Uh oh!

4brunu commented Mar 21, 2022

Uh oh!

moljac commented Mar 21, 2022

Uh oh!

4brunu commented Mar 23, 2022

Uh oh!

moljac commented Mar 23, 2022

Uh oh!

4brunu commented Mar 23, 2022

Uh oh!

moljac commented Jul 22, 2022

Uh oh!

azure-pipelinesBot commented Jul 22, 2022

Uh oh!

moljac commented Jul 26, 2022

Uh oh!

4brunu commented Jul 26, 2022

Uh oh!

4brunu commented Jul 26, 2022

Uh oh!

4brunuJul 26, 2022

Choose a reason for hiding this comment

Uh oh!

4brunuJul 26, 2022

Choose a reason for hiding this comment

Uh oh!

moljac commented Aug 6, 2022

Uh oh!

moljac commented Aug 6, 2022

Uh oh!

4brunu commented Aug 6, 2022

Uh oh!

moljac commented Aug 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

4brunu commented Dec 9, 2021•
edited
Loading