Fix AdbRunner AVD detection: use getprop first, skip offline emulators

[rmarinho]

Summary

Two fixes for AdbRunner emulator detection reliability, discovered while investigating dotnet/android#10965.

Related PR: dotnet/android#10969

1. Swap AVD name detection order (GetEmulatorAvdNameAsync)

adb -s <serial> emu avd name returns empty output on modern Android emulators (tested with emulator 36.4.10, adb v36). This causes AVD name matching to fail even when the correct emulator is running.

Fix: Use adb shell getprop ro.boot.qemu.avd_name first (reliable on all modern emulators, always set by the emulator kernel), fall back to emu avd name for older emulator versions.

2. Skip AVD name queries for offline emulators (ListDevicesAsync)

ListDevicesAsync called GetEmulatorAvdNameAsync for ALL emulators including offline ones. Neither getprop nor emu avd name works on offline devices — they fail or timeout. During boot polling loops, this causes unnecessary delays on every iteration as the emulator transitions from offline → online.

Fix: Only query AVD names for online emulators (Status == AdbDeviceStatus.Online).

Testing

• All 47 AdbRunner tests pass
• Full test suite: 241 passed, 1 pre-existing env-specific failure, 10 skipped (require device)
• Verified end-to-end on macOS with emulator 36.4.10

[Copilot]

Pull request overview

Improves Xamarin.Android.Tools.AndroidSdk’s AdbRunner emulator AVD detection to better handle modern emulator behavior and avoid slow/failed AVD queries while emulators are offline (e.g., during boot polling).

Changes:

• Prefer adb shell getprop ro.boot.qemu.avd_name for emulator AVD name detection, with fallback to adb emu avd name.
• Skip AVD-name probing for offline emulators in ListDevicesAsync (and optionally log the skip).
• Add/extend unit tests covering the detection order and offline-emulator handling.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
tests/Xamarin.Android.Tools.AndroidSdk-Tests/AdbRunnerTests.cs	Adds new tests using a fake adb implementation to validate AVD detection and offline handling.
src/Xamarin.Android.Tools.AndroidSdk/Runners/AdbRunner.cs	Updates AVD name query order; skips offline emulators; adds optional logger parameter.
src/Xamarin.Android.Tools.AndroidSdk/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt	Updates public API entry for the AdbRunner constructor signature change.
src/Xamarin.Android.Tools.AndroidSdk/PublicAPI/net10.0/PublicAPI.Unshipped.txt	Updates public API entry for the AdbRunner constructor signature change.

---

You can also share your feedback on Copilot code review. Take the survey.

[jonathanpeppers]

I thought we had a [DllImport] for this somewhere? Can the test call a method from ProcessUtils (or whereever that was?)

[rmarinho]

Done — replaced Process.Start("chmod") with FileUtil.Chmod(path, 0x1ED) which uses File.SetUnixFileMode on .NET 7+ and the [DllImport("libc")] chmod on older runtimes. Also replaced the null-forgiving ! on Path.GetDirectoryName() with is { Length: > 0 } property pattern per repo conventions.