[tests] run `Java.Interop-Tests` on NativeAOT by jonathanpeppers · Pull Request #10496 · dotnet/android

jonathanpeppers · 2025-09-17T19:16:15Z

In 32fcc8b, I enabled tests related to the "GC Bridge" on NativeAOT, but discovered we still weren't running dotnet/java-interop's tests. Let's enable them.

We can also remove $(DefineConstants) for CORECLR and NATIVEAOT as there is nothing using these.

In 32fcc8b, I enabled tests related to the "GC Bridge" on NativeAOT, but discovered we still weren't running dotnet/java-interop's tests. Let's enable them. We can also remove `$(DefineConstants)` for `CORECLR` and `NATIVEAOT` as there is nothing using these.

jonathanpeppers · 2025-09-18T13:43:36Z

This one crashes with:

09-17 20:22:12.204 9703 9724 I NUnit : RegisterWithVM_PermitsAliases 09-17 20:22:12.204 9703 9724 I NUnit : Passed
09-17 20:22:12.204 9703 9724 I NUnit : UnreferencedInstanceIsCollected 09-17 20:22:12.227 9703 9723 I droid.NET_Test: Explicit concurrent copying GC freed 47(62KB) AllocSpace objects, 0(0B) LOS objects, 52% free, 1366KB/2902KB, paused 2.044ms total 12.476ms
09-17 20:22:12.242 9703 9723 I droid.NET_Test: Explicit concurrent copying GC freed 3(16KB) AllocSpace objects, 0(0B) LOS objects, 52% free, 1366KB/2902KB, paused 2.037ms total 10.965ms
09-17 20:22:12.243 9703 9741 F monodroid: The method is not implemented. This is a stub and should not be called.
09-17 20:22:12.243 9703 9741 F monodroid: Abort at internal-pinvoke-stubs.cc:10:3 ('void (anonymous namespace)::pinvoke_unreachable()')
--------- beginning of crash
09-17 20:22:12.243 9703 9741 F libc : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 9741 (Thread-15), pid 9703 (droid.NET_Tests)
09-17 20:22:12.292 9760 9760 I crash_dump64: obtaining output fd from tombstoned, type: kDebuggerdTombstone
09-17 20:22:12.301 1870 1870 I /system/bin/tombstoned: received crash request for pid 9741
09-17 20:22:12.303 9760 9760 I crash_dump64: performing dump of process 9703 (target tid = 9741)
09-17 20:22:12.308 9760 9760 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
09-17 20:22:12.309 9760 9760 F DEBUG : Build fingerprint: 'Android/sdk_phone_x86_64/generic_x86_64:10/QSR1.210820.001/7663313:userdebug/test-keys'
09-17 20:22:12.309 9760 9760 F DEBUG : Revision: '0'
09-17 20:22:12.309 9760 9760 F DEBUG : ABI: 'x86_64'
09-17 20:22:12.312 9760 9760 F DEBUG : Timestamp: 2025-09-17 20:22:12+0000
09-17 20:22:12.312 9760 9760 F DEBUG : pid: 9703, tid: 9741, name: Thread-15 >>> Mono.Android.NET_Tests <<<
09-17 20:22:12.312 9760 9760 F DEBUG : uid: 10121
09-17 20:22:12.312 9760 9760 F DEBUG : signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr --------
09-17 20:22:12.312 9760 9760 F DEBUG : Abort message: 'The method is not implemented. This is a stub and should not be called.'
09-17 20:22:12.312 9760 9760 F DEBUG : rax 0000000000000000 rbx 00000000000025e7 rcx 000072e776f643f8 rdx 0000000000000006
09-17 20:22:12.312 9760 9760 F DEBUG : r8 000072e69daf3356 r9 0000000000000000 r10 000072e5205a54f0 r11 0000000000000246
09-17 20:22:12.313 9760 9760 F DEBUG : r12 000072e69daf3356 r13 000072e69daf9345 r14 000072e5205a5578 r15 000000000000260d
09-17 20:22:12.313 9760 9760 F DEBUG : rdi 00000000000025e7 rsi 000000000000260d
09-17 20:22:12.313 9760 9760 F DEBUG : rbp 000072e5205a57e0 rsp 000072e5205a54e8 rip 000072e776f643f8
09-17 20:22:12.412 9760 9760 F DEBUG : 09-17 20:22:12.412 9760 9760 F DEBUG : backtrace:
09-17 20:22:12.413 9760 9760 F DEBUG : #00 pc 00000000000943f8 /apex/com.android.runtime/lib64/bionic/libc.so (syscall+24) (BuildId: b5c6019a3b4ea61b5e9a2f56319b584e)
09-17 20:22:12.414 9760 9760 F DEBUG : #01 pc 0000000000097146 /apex/com.android.runtime/lib64/bionic/libc.so (abort+182) (BuildId: b5c6019a3b4ea61b5e9a2f56319b584e)
09-17 20:22:12.414 9760 9760 F DEBUG : #02 pc 000000000010409f /data/app/Mono.Android.NET_Tests-Gfdg4USGyH70bxzMdRh4Tw==/split_config.x86_64.apk

Context: 869b0e0 The `pinvoke_unreachable` function, when invoked, would log its own source location instead of that of the call site. That's a bit useless in diagnosing issues, so let's improve it by logging the call site location... :)

grendello · 2025-09-19T07:40:49Z

I added the #10502 change to this PR, it should give us better info on which p/invoke was called.

Context: #10496 (comment) Context: 869b0e0 The `_monodroid_weak_gref_delete` p/invoke wasn't implemented in 869b0e0 as it was thought to be unused. However, the test failure in #10496 shows that it's not true. Bring the `_monodroid_weak_gref_delete` implementation to NativeAOT host from the CoreCLR host.

grendello · 2025-09-19T13:36:04Z

Comitted the change in #10504 to this PR, it implements _monodroid_weak_gref_delete, the p/invoke that causing the crash.

jonathanpeppers · 2025-09-19T15:00:15Z

Now we are beyond the crash, there are test failures that are probably bugs:

Mono.Android.NET_Tests, Java.InteropTests.JniPeerMembersTests.ReplaceStaticMethodName / Release
Java.Lang.NoSuchMethodError : no static method "Ljava/lang/Runtime;.remappedToGetRuntime()Ljava/lang/Runtime;"

Seems like some package name or text is missing before the .remappedToGetRuntime value.

Context: #10496 (comment) Context: 869b0e0 The `_monodroid_weak_gref_delete` p/invoke wasn't implemented in 869b0e0 as it was thought to be unused. However, the test failure in #10496 shows that it's not true. Bring the `_monodroid_weak_gref_delete` implementation to NativeAOT host from the CoreCLR host.

Resolve 3 merge conflicts: - internal-pinvokes-clr.cc: accept main's removal of _monodroid_timezone_get_default_id (moved elsewhere) - internal-pinvoke-stubs.cc: accept main's removal of _monodroid_timezone_get_default_id stub - Mono.Android.NET-Tests.csproj: keep PR's removal of CORECLR/NATIVEAOT DefineConstants Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The function already exists with [[maybe_unused]] on from_writable and correctly calls OSBridge with 5 args. The duplicate caused: - redefinition error (same C++ signature) - wrong arg count (OSBridge only takes 5 args, not 6) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Three changes to ManagedTypeManager (the NativeAOT type manager): 1. Add GetStaticMethodFallbackTypesCore override - returns Desugar{name} and {name}$-CC fallback types for desugared interface static methods. Fixes: DesugarInterfaceStaticMethod test. 2. Reorder GetTypesForSimpleReference to yield base class results first. The base JniTypeManager has built-in mappings (java/lang/String to System.String, java/lang/Float to float?, etc.) that must take priority over ManagedTypeMapping (which returns Java.Lang.String). Fixes: GetType, GetTypeSignature, and JavaObjectArray equality tests. 3. Call base.RegisterNativeMembers when methods string is empty, so the base class can find and invoke [JniAddNativeMethodRegistrationAttribute] methods. Previously ManagedTypeManager returned early, skipping this. Fixes: InvokeVirtualFromConstructorTests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The fallback type must include the \ suffix to match the actual desugared companion class name (e.g. DesugarAndroidInterface\). This matches the pattern used by the Java.Interop test fixture. Fixes DesugarInterfaceStaticMethod test on NativeAOT. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Adds [Category("NativeAOTIgnore")] to InvokeVirtualFromConstructorTests. Tracking: #10950 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Enables running dotnet/java-interop tests (Java.Interop-Tests) under NativeAOT and adjusts runtime type resolution behavior to support those tests, while simplifying test project build constants.

Changes:

Always include Java.Interop-Tests in the runtime test assembly list (removes the NativeAOT exclusion).
Remove now-unneeded CORECLR/NATIVEAOTDefineConstants from the test project.
Update ManagedTypeManager type mapping priority and add fallback type name generation for desugared static methods.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.RuntimeTests/NUnitInstrumentation.cs	Runs `Java.Interop-Tests` on NativeAOT by always including the assembly in instrumentation.
tests/Mono.Android-Tests/Mono.Android-Tests/Mono.Android.NET-Tests.csproj	Removes unused conditional compilation constants for `CORECLR`/`NATIVEAOT`.
src/Mono.Android/Microsoft.Android.Runtime/ManagedTypeManager.cs	Adjusts type-mapping precedence and adds fallback type-name logic for desugared static method resolution.
external/Java.Interop	Updates the Java.Interop submodule revision, likely containing fixes needed for NativeAOT test execution.

Replace StringBuilder with simple string interpolation. Also removes unused System.Text using. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

grendello mentioned this pull request Sep 19, 2025
[nativeaot] Implement _monodroid_weak_gref_delete #10504
Merged

simonrozsival mentioned this pull request Jan 6, 2026
[Android] CoreCLR support in .NET 11 dotnet/maui#33386
Open
26 tasks

jonathanpeppers force-pushed the dev/peppers/java-interop-tests-nativeaot branch from 39e3ff3 to 6c349a2Compare March 12, 2026 19:36

jonathanpeppers mentioned this pull request Mar 13, 2026
Add [Category("NativeAOTIgnore")] to JNI method remapping tests dotnet/java-interop#1388
Closed

CopilotAI mentioned this pull request Mar 13, 2026
Add [Category("NativeAOTIgnore")] to JNI method remapping tests dotnet/java-interop#1389
Merged

jonathanpeppersand others added 3 commits March 13, 2026 16:44

Merge branch 'main' into dev/peppers/java-interop-tests-nativeaot
71860e3

This was referenced Mar 16, 2026
[NativeAOT] PreserveRegistrations does not handle [JniAddNativeMethodRegistrationAttribute] delegate types #10950
Open
[tests] Add NativeAOTIgnore to InvokeVirtualFromConstructorTests dotnet/java-interop#1390
Merged

Bump todotnet/java-interop@fb0952fa
e15598b
Adds [Category("NativeAOTIgnore")] to InvokeVirtualFromConstructorTests. Tracking: #10950 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jonathanpeppers added the copilot `copilot-cli` or other AIs were used to author this label Mar 16, 2026

jonathanpeppers marked this pull request as ready for review March 16, 2026 17:39

jonathanpeppers requested review from grendello and simonrozsival as code owners March 16, 2026 17:39

CopilotAI review requested due to automatic review settings March 16, 2026 17:39

CopilotAI reviewed Mar 16, 2026
View reviewed changes

Comment threadsrc/Mono.Android/Microsoft.Android.Runtime/ManagedTypeManager.cs
Comment threadsrc/Mono.Android/Microsoft.Android.Runtime/ManagedTypeManager.cs
Comment threadsrc/Mono.Android/Microsoft.Android.Runtime/ManagedTypeManager.cs

Simplify GetStaticMethodFallbackTypesCore to use string interpolation
b8f3905
Replace StringBuilder with simple string interpolation. Also removes unused System.Text using. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

simonrozsival approved these changes Mar 16, 2026
View reviewed changes

jonathanpeppers merged commit d0f4507 into mainMar 16, 2026
5 of 6 checks passed

jonathanpeppers deleted the dev/peppers/java-interop-tests-nativeaot branch March 16, 2026 20:40

github-actionsBot locked and limited conversation to collaborators Apr 16, 2026

Navigation Menu

Uh oh!

[tests] run `Java.Interop-Tests` on NativeAOT - #10496

[tests] run `Java.Interop-Tests` on NativeAOT#10496
jonathanpeppers merged 10 commits into
mainfrom
dev/peppers/java-interop-tests-nativeaot

jonathanpeppers commented Sep 17, 2025

Uh oh!

jonathanpeppers commented Sep 18, 2025

Uh oh!

grendello commented Sep 19, 2025

Uh oh!

grendello commented Sep 19, 2025

Uh oh!

jonathanpeppers commented Sep 19, 2025

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jonathanpeppers commented Sep 17, 2025

Uh oh!

jonathanpeppers commented Sep 18, 2025

Uh oh!

grendello commented Sep 19, 2025

Uh oh!

grendello commented Sep 19, 2025

Uh oh!

jonathanpeppers commented Sep 19, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants