Uh oh!
There was an error while loading. Please reload this page.
Enable more tests to run on all 3 runtimes, part 13 - #10635
Conversation
7e3f8f4 to
a45dafcCompare1fc2bd5 to
f728327Comparegrendello
commented
Dec 12, 2025
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
a6f8ea0 to
f802ad8Compare4a71530 to
e5a3fb0Comparee5a3fb0 to
d305b94CompareThere was a problem hiding this comment.
Pull request overview
This pull request extends test coverage in InstallAndRunTests.cs by modifying test methods to run on all three Android runtimes (MonoVM, CoreCLR, and NativeAOT) instead of being limited to specific runtimes. The PR is part of a series (part 13) aimed at improving runtime test coverage.
Changes:
- Converted multiple test methods from [TestCase] attributes to [Values] attributes with AndroidRuntime parameter
- Added runtime-specific package name generation using
PackageUtils.MakePackageName(runtime) - Added
IgnoreUnsupportedConfigurationchecks and runtime-specificAssert.Ignorestatements for known limitations - Created test data generator methods
Get_DotNetRun_DataandGet_SmokeTestBuildAndRunWithSpecialCharacters_Datato generate test combinations
Comments suppressed due to low confidence (1)
tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs:448
- Condition is always false because of ... == ....
AndroidRuntime.CoreCLR => null, // CoreCLR explicitly passes a `null` sender
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fa9fd76 to
ffa9f47Compare0cbf89d to
d7ea1ecCompare9a3581e to
a40eebaCompare88f92ec to
0286907CompareCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
db1ff4f to
e8e1146Compare
This pull request primarily refactors and improves test utility methods and logging for better maintainability and clarity. The most important changes include refactoring how MSBuild warnings are asserted in tests, improving debug logging in marshal method generation, and making test timeouts more maintainable by using a constant.
Test utilities and assertion improvements:
AssertHasNoWarningsandAssertHasSomeWarningsmethods inAssertionExtensions.csto reduce duplication and centralize the logic for asserting the number of MSBuild warnings. Now, both methods delegate to a shared implementation, improving maintainability.using System.Collections.Generic;directive inAssertionExtensions.csto support the refactored methods.Logging improvements:
MarshalMethodsNativeAssemblyGenerator.csto include the native symbol name when generating marshal methods, providing more context for debugging.Test timeout maintainability:
MonoAndroidExportTest.csto use the shared constantInstallAndRunTests.ActivityStartTimeoutInSeconds, improving consistency and ease of configuration. [1][2]