Skip to content

[TrimmableTypeMap][Core C] JavaPeerScanner logic - #10818

Closed
simonrozsival wants to merge 4 commits into
dotnet:dev/simonrozsival/ttm-core-b-indexfrom
simonrozsival:dev/simonrozsival/ttm-core-c-scanner-only
Closed

[TrimmableTypeMap][Core C] JavaPeerScanner logic#10818
simonrozsival wants to merge 4 commits into
dotnet:dev/simonrozsival/ttm-core-b-indexfrom
simonrozsival:dev/simonrozsival/ttm-core-c-scanner-only

Conversation

@simonrozsival

@simonrozsivalsimonrozsival commented Feb 14, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Core slice C from #10805.

Scope

  • JavaPeerScanner execution logic over indexed metadata
  • Scanner orchestration paths for peer discovery and extraction

Notes

  • Draft slice for focused scanner-logic review.
  • Complements the foundation/index slices.

@simonrozsivalsimonrozsival changed the title [TrimmableTypeMap][Core C] JavaPeerScanner logic preview (<1k)[TrimmableTypeMap][Core C] JavaPeerScanner logicFeb 14, 2026
@simonrozsival
simonrozsival changed the base branch from main to dev/simonrozsival/ttm-core-b-indexFebruary 14, 2026 00:19
This was referenced Feb 14, 2026
Merged
Closed
@simonrozsivalsimonrozsival added copilot `copilot-cli` or other AIs were used to author this trimmable-type-map Area: CoreCLR Issues that only occur when using CoreCLR. Area: NativeAOT Issues that only occur when using NativeAOT. labels Feb 14, 2026
@simonrozsival
simonrozsivalforce-pushed the dev/simonrozsival/ttm-core-b-index branch from 23e6975 to 9822cf0CompareFebruary 14, 2026 09:35
@simonrozsival

simonrozsival commented Feb 14, 2026

Copy link
Copy Markdown
MemberAuthor

Applied all style feedback from downstream reviews: null patterns (is null/is not null), string interpolation, and updated scanner to use new typed TypeAttributeInfo model hierarchy. All changes verified to compile.

@simonrozsival
simonrozsivalforce-pushed the dev/simonrozsival/ttm-core-b-index branch from 9822cf0 to 2f303edCompareFebruary 15, 2026 15:37
simonrozsivaland others added 4 commits February 16, 2026 16:06
@simonrozsival
[TrimmableTypeMap][Core C] Scanner execution logic preview (<1k)
59897dd
@simonrozsival
[TrimmableTypeMap][Core C] Apply review style and type-model updates
e905c7e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
[TrimmableTypeMap][Core C] Use null pattern in interface JNI check
6445238
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
[TrimmableTypeMap][Core C] Adapt scanner to refactored AssemblyIndex
b6895af
- Remove Phase 1b (JniNameProviderAttribute merging/reclassification)
- Use record 'with' expression for immutable ForceUnconditionalIfPresent
- Use .IsNullOrEmpty() extension method
- Use record init syntax for RegisterInfo and ExportInfo construction
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsivalforce-pushed the dev/simonrozsival/ttm-core-b-index branch from 2f303ed to 3fe1722CompareFebruary 16, 2026 15:08
@simonrozsivalsimonrozsival mentioned this pull request Feb 16, 2026
Merged
@simonrozsival

simonrozsival commented Feb 16, 2026

Copy link
Copy Markdown
MemberAuthor

Closing: merged into unified PR #10823. The Core A/B/C split was too granular — a single scanner-core PR is more practical for review while still being much smaller than the original #10805.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 19, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonathanpeppersjonathanpeppersAwaiting requested review from jonathanpeppersjonathanpeppers will be requested when the pull request is marked ready for reviewjonathanpeppers is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Area: CoreCLRIssues that only occur when using CoreCLR.Area: NativeAOTIssues that only occur when using NativeAOT.copilot`copilot-cli` or other AIs were used to author this

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@simonrozsival