Uh oh!
There was an error while loading. Please reload this page.
[TrimmableTypeMap] Add GetStaticMethodFallbackTypesCore override for desugared default interface methods - #11050
Conversation
simonrozsival
commented
Mar 31, 2026
@copilot continue |
…Manager Agent-Logs-Url: https://github.com/dotnet/android/sessions/1eb1fc88-df89-4cb7-bd45-15187eea3776 Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Added the |
There was a problem hiding this comment.
Pull request overview
Adds support in the trimmable typemap runtime type manager for resolving Java 8+ desugared default interface method companion classes during JNI static method lookup, preventing runtime NoSuchMethodError when default interface methods are used.
Changes:
- Added
GetStaticMethodFallbackTypesCore()override toTrimmableTypeMapTypeManager. - Implemented desugar companion-class fallback name generation (
Desugar{Type}$_CCand{Type}$-CC) consistent withManagedTypeManager.
Uh oh!
There was an error while loading. Please reload this page.
…Core Agent-Logs-Url: https://github.com/dotnet/android/sessions/66cf81ea-433f-43ac-8c85-45bb0483a230 Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Adds
GetStaticMethodFallbackTypesCoreoverride toTrimmableTypeMapTypeManagerto support Java 8+ default interface methods desugared by D8/R8.Problem
TrimmableTypeMapTypeManagerdid not overrideGetStaticMethodFallbackTypesCore(). Without this, calls to desugared default interface methods fail withNoSuchMethodErrorat runtime when using the trimmable type map. This affects any app using Java libraries with default interface methods (Java 8+ feature, very common in modern Android libraries like AndroidX).Fix
Added the same override that already exists in
ManagedTypeManagertoTrimmableTypeMapTypeManager:This generates two fallback type names for desugared companion classes (
Desugar{Type}$_CCand{Type}$-CC) so that JNI static method lookups on desugared default interface methods succeed at runtime.Tests
Added
TrimmableTypeMapTypeManagerTeststotests/Mono.Android-Tests/Mono.Android-Tests/Java.Interop/to verify the fallback type generation. The tests use a subclass ofTrimmableTypeMapTypeManager(accessible via the existingInternalsVisibleToinMono.Android) and cover three cases:android/app/Activity)Activity)com/example/package/MyInterface)