Skip to content

Avoid O(n²) array growth in GenerateTypeMappings#11127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 2 commits into from
Apr 16, 2026
Merged

Avoid O(n²) array growth in GenerateTypeMappings #11127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8149d8
Use List<ITaskItem> to avoid O(n²) array growth in GenerateTypeMappings
jonathanpeppers Apr 16, 2026
1195bcb
Remove intermediate List in AddOutputTypeMaps
jonathanpeppers Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Xamarin.Android.Build.Tasks/Tasks/GenerateTypeMappings.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ public class GenerateTypeMappings : AndroidTask
public string TypemapOutputDirectory { get; set; } = "";

AndroidRuntime androidRuntime;
readonly List<ITaskItem> generatedBinaryTypeMaps = new List<ITaskItem> ();
Comment thread
jonathanpeppers marked this conversation as resolved.

public override bool RunTask ()
{
Expand All@@ -71,6 +72,7 @@ public override bool RunTask ()
if (RunCheckedBuild || useMarshalMethods)
GenerateAllTypeMappingsFromNativeState (useMarshalMethods);

GeneratedBinaryTypeMaps = generatedBinaryTypeMaps.ToArray ();
return !Log.HasLoggedErrors;
}

Expand DownExpand Up@@ -153,17 +155,14 @@ void GenerateTypeMapFromNativeState (NativeCodeGenState state, bool useMarshalMe
void AddOutputTypeMaps (TypeMapGenerator tmg, AndroidTargetArch arch)
{
string abi = MonoAndroidHelper.ArchToAbi (arch);
var items = new List<ITaskItem> ();

foreach (string file in tmg.GeneratedBinaryTypeMaps) {
var item = new TaskItem (file);
string fileName = Path.GetFileName (file);
item.SetMetadata ("DestinationSubPath", $"{abi}/{fileName}");
item.SetMetadata ("DestinationSubDirectory", $"{abi}/");
item.SetMetadata ("Abi", abi);
items.Add (item);
generatedBinaryTypeMaps.Add (item);
}

GeneratedBinaryTypeMaps = GeneratedBinaryTypeMaps.Concat (items).ToArray ();
}
}