[typemap] Honor explicit interface invokers

[simonrozsival]

Summary

• consume same-assembly JniTypeSignatureAttribute.InvokerType metadata
• resolve the invoker activation constructor style from its declaring assembly
• prefer the validated explicit proxy for requested interface and abstract targets
• retain existing most-derived hierarchy behavior for concrete targets
• ignore unsupported cross-assembly invoker metadata
• add constructor-based XA, Java.Interop, inherited-interface, abstract-type, and peer-identity coverage

TDD matrix

Before the fix, the unchanged explicit-invoker test passed with llvm-ir but selected the wrong proxy under both trimmable runtimes. After the fix:

• llvm-ir + CoreCLR: 4/4
• trimmable + CoreCLR: 4/4
• trimmable + NativeAOT: 4/4

Microsoft.Android.Sdk.TrimmableTypeMap.Tests: 774/774.

Part of #12561

[Copilot]

Copilot review overview

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	tests/​Microsoft.Android.Sdk.TrimmableTypeMap.Tests/​TestFixtures/​InvokerFixtures.cs — 💡 suggestion: The explicit invoker/proxy type should implement the target interface; otherwise this…

What changed in this PR

This PR closes a TrimmableTypeMap feature-parity gap by honoring explicit invoker metadata (including same-assembly JniTypeSignatureAttribute.InvokerType) and adjusting runtime proxy selection so interface/abstract targets prefer the explicitly validated proxy while concrete targets keep the existing “most-derived” behavior.

Changes:

• Update runtime proxy resolution to prefer explicit proxies for interface/abstract targets while preserving hierarchy-first behavior for concrete targets.
• Extend the trimmable typemap scanner to consume same-assembly explicit invoker metadata and resolve invoker activation constructor style from the declaring assembly (ignoring unsupported cross-assembly invokers).
• Add new device/runtime and scanner coverage for invoker activation, inherited interfaces, abstract targets, and peer identity.

File	Description
tests/​Mono.Android-Tests/​Mono.Android-Tests/​Mono.Android.NET-Tests.csproj	Adds the new invoker activation test file to the device test project.
tests/​Mono.Android-Tests/​Mono.Android-Tests/​Java.Interop/​InvokerActivationTests.cs	New device tests validating invoker selection, single activation, and identity preservation.
tests/​Microsoft.Android.Sdk.TrimmableTypeMap.Tests/​TestFixtures/​StubAttributes.cs	Extends the stub JniTypeSignatureAttribute to support interfaces and InvokerType.
tests/​Microsoft.Android.Sdk.TrimmableTypeMap.Tests/​TestFixtures/​InvokerFixtures.cs	New fixtures for explicit-invoker scanning scenarios (including cross-assembly ignore case).
tests/​Microsoft.Android.Sdk.TrimmableTypeMap.Tests/​Scanner/​JavaPeerScannerTests.cs	Adds scanner tests covering explicit invokers and cross-assembly ignore behavior.
src/​Mono.Android/​Microsoft.Android.Runtime/​TrimmableTypeMap.cs	Adjusts runtime proxy selection ordering for interface/abstract targets.
src/​Microsoft.Android.Sdk.TrimmableTypeMap/​Scanner/​JavaPeerScanner.cs	Implements same-assembly invoker resolution + assembly-scoped activation ctor style lookup.
src/​Microsoft.Android.Sdk.TrimmableTypeMap/​Scanner/​AssemblyIndex.cs	Captures InvokerType from JniTypeSignature into RegisterInfo for scanner consumption.

Suppressed comments (1)

tests/Microsoft.Android.Sdk.TrimmableTypeMap.Tests/TestFixtures/InvokerFixtures.cs:23

• 💡 suggestion: Same as above: the proxy type used as an explicit invoker should implement the interface it is meant to represent, so the fixture reflects a valid runtime invoker shape.

public sealed class InheritedJavaInteropListProxy : Java.Lang.Object

[simonrozsival]

/review

[github-actions]

✅ Android PR Reviewer completed successfully!

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• azcliprod.blob.core.windows.net

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "azcliprod.blob.core.windows.net"

See Network Configuration for more information.

Generated by Android PR Reviewer for #12565

[github-actions]

⚠️ Needs Changes

Found 1 error: the new interface/abstract target-first lookup can lose Java peer identity when callers request the same object first through an interface and later through its concrete class. The inline comment includes the failure sequence and requested regression coverage.

The scanner-side same-assembly validation and explicit-invoker fixture coverage are well targeted. CI is currently red in dotnet-android (Package Tests macOS > Tests > APKs 2); the remaining checks passed, but the Azure failure details were unavailable from this run because the Azure CLI requires authentication.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• azcliprod.blob.core.windows.net

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "azcliprod.blob.core.windows.net"

See Network Configuration for more information.

Generated by Android PR Reviewer for #12565 · gpt56 · 292.7 AIC · ⌖ 8.93 AIC · ⊞ 25.7K
_{Comment /review to run again}