Uh oh!
There was an error while loading. Please reload this page.
[build] Mark AndroidSdk package as prerelease - #12604
Merged
Merged
Conversation
Use an AndroidSdk-only preview suffix for its NuGet package version so promotion can publish it to the non-isolated transport feed. Keep Microsoft.Android.Build.BaseTasks on its existing stable-style version. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 325ffe1d-b572-4873-88d1-f359670fcb20
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
This PR adjusts NuGet versioning for the in-tree Xamarin.Android.Tools.AndroidSdk package so it is published as a prerelease (e.g., 37.0.0-preview.<commitCount>), while leaving the shared tools versioning behavior unchanged for other packages that import the same versioning targets.
Changes:
- Set a project-local
_AndroidToolsPackageVersionSuffixtopreviewforXamarin.Android.Tools.AndroidSdk. - Update
Xamarin.Android.Tools.Versioning.targetsto emit a prereleasePackageVersionwhen that suffix is provided.
File summaries
| File | Description |
|---|---|
| src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj | Sets a private version-suffix property so only this package gets a prerelease NuGet version. |
| build-tools/scripts/Xamarin.Android.Tools.Versioning.targets | Adds conditional PackageVersion computation to incorporate the optional prerelease suffix. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
Uh oh!
There was an error while loading. Please reload this page.
simonrozsival
approved these changes
Aug 31, 2026
Fetch complete history in the macOS and Windows package-building jobs so AndroidSdk can calculate its commit-distance package and assembly versions instead of using the shallow-checkout fallback of zero. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 325ffe1d-b572-4873-88d1-f359670fcb20
This reverts commit 7932edc.
jonathanpeppers
commented
Aug 31, 2026
MemberAuthor
Ok this is ready, I went back and forth with copilot as the version was wrong on the PR build. But I think it will be correct when merged. |
Uh oh!
There was an error while loading. Please reload this page.
jonathanpeppers
deleted the
jonathanpeppers-preview-androidsdk-version
branch
September 1, 2026 00:33
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
title and
description
should follow the
commit-messages.mdworkflow documentation, and in particular should include:The Build Promotion Pipeline failure rejects
Xamarin.Android.Tools.AndroidSdkbecause its stable-looking package version is targeted at the non-isolated .NET 11 transport feed:Give only the AndroidSdk package a
previewsuffix. The failing full-history build's37.0.2353therefore becomes37.0.0-preview.2353. The shared versioning target retains its existing default, soMicrosoft.Android.Build.BaseTaskskeeps its current versioning behavior.The prerelease suffix applies only to
PackageVersion; the numeric assemblyVersionremains distance-based. Consecutive full-history builds therefore remain distinct to .NET Framework as assembly versions such as37.0.2361.0and37.0.2362.0, while NuGet sees package versions37.0.0-preview.2361and37.0.0-preview.2362.PR validation uses a shallow checkout, where the existing versioning fallback intentionally produces distance
0. The downloaded PR artifact is therefore37.0.0-preview.0; release builds retain the real commit distance.