Uh oh!
There was an error while loading. Please reload this page.
[msbuild] default value for JavaMaximumHeapSize - #1436
Merged
Conversation
Fixesdotnet#1415 Commonly Xamarin.Android apps on Windows require the `JavaMaximumHeapSize` property to be set, in order to make it past the `CompileToDalvik` MSBuild task that invokes `dx.jar`. Passing `java.exe` a value of `-Xmx1G` mitigates the `java.lang.OutOfMemoryError`. We have been getting reports of this happening for File->New Project templates, so it seems to be time to default the value to `1G` if it is not set. Changes: - Set `JavaMaximumHeapSize` in `Xamarin.Android.Common.targets` if unset - Removed places `JavaMaximumHeapSize` was required to be set for some unit tests to pass on Windows - Update documentation Concerns: At one time, a default value for `JavaMaximumHeapSize` was attempted, only to get reports of an error such as: While trying to start a Java application with a maximum heap size of 1GB, you receive the following error: "JVMJ9VM015W Initialization error for library j9gc24(2): Failed to instantiate heap; 1G requested Could not create the Java virtual machine. Hopefully, this was something that was happening for older JDK versions in the past on Windows.
dellis1972
approved these changes
Mar 16, 2018
jonpryor pushed a commit
that referenced
this pull request
Mar 21, 2018
Fixes: #1415 Commonly Xamarin.Android apps on Windows require the `$(JavaMaximumHeapSize)` property to be set, in order to make it past the `CompileToDalvik` MSBuild task that invokes `dx.jar`. Passing `java.exe` a value of `-Xmx1G` often avoids the `java.lang.OutOfMemoryError` We have been getting reports of this happening for **File** > **New Project** templates, so it seems to be time to default the value to `1G` if it is not set. Changes: - Set `$(JavaMaximumHeapSize)` in `Xamarin.Android.Common.targets` if not overridden. - Removed places `$(JavaMaximumHeapSize)` was required to be set for some unit tests to pass on Windows - Update documentation Concerns: At one time, a default value for `$(JavaMaximumHeapSize)` was attempted, only to get [reports of an error][0] such as: JVMJ9VM015W Initialization error for library j9gc24(2): Failed to instantiate heap; 1G requested Could not create the Java virtual machine. Hopefully, this was something that was happening for older JDK versions in the past on Windows. [0]: https://www.ibm.com/developerworks/community/blogs/aimsupport/entry/why_wont_my_jvm_start_with_this_heap_size?lang=en
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1415
Commonly Xamarin.Android apps on Windows require the
JavaMaximumHeapSizeproperty to be set, in order to make it past the
CompileToDalvikMSBuild task that invokes
dx.jar. Passingjava.exea value of-Xmx1Gmitigates thejava.lang.OutOfMemoryError.We have been getting reports of this happening for File->New Project
templates, so it seems to be time to default the value to
1Gif itis not set.
Changes:
JavaMaximumHeapSizeinXamarin.Android.Common.targetsif unsetJavaMaximumHeapSizewas required to be set forsome unit tests to pass on Windows
Concerns:
At one time, a default value for
JavaMaximumHeapSizewas attempted,only to get reports of an error such as:
Hopefully, this was something that was happening for older JDK versions in
the past on Windows.