Uh oh!
There was an error while loading. Please reload this page.
[tests] Run .apk unit tests and collect TestResults.xml - #305
Merged
Conversation
jonpryorforce-pushed
the
jonp-run-tests
branch
from
November 19, 2016 23:16
2f0e29c to
3e1343eCompare| : new [] { ToolPath }; | ||
| string filename; | ||
| var path = Which.GetProgramLocation (ToolBaseName, out filename, dirs); | ||
| Log.LogMessage ($"# jonp: PathToolTask.GenerateFullPathToTool: path={path}"); |
Contributor
There was a problem hiding this comment.
Does this need to have "# jonp:" :P
| } | ||
| } | ||
| public static string GetProgramLocation (string programBasename, out string filename, string[] directories = null) |
| return null; | ||
| } | ||
| static string GetProgramLocation (string programBasename, string directory, out string filename) |
| Targets = targets?.ToArray (); | ||
| // Log.LogMessage (MessageImportance.Low, $" [Output] {nameof (AdbTarget)}: {AdbTarget}"); | ||
| // Log.LogMessage (MessageImportance.Low, $" [Output] {nameof (IsValidTarget)}: {IsValidTarget}"); |
Contributor
There was a problem hiding this comment.
should these be outputting "TargetId" and "Targets"?
| string line; | ||
| while ((line = p.StandardOutput.ReadLine ()) != null) { | ||
| yield return line; |
Contributor
There was a problem hiding this comment.
interesting use of yield here... I like it :)
jonpryorforce-pushed
the
jonp-run-tests
branch
from
November 21, 2016 14:06
3e1343e to
78c0e9fCompareWhat do we want? Execution of unit tests! When do we want it? Uh...4 months ago? The `Xamarin.Android.NUnitLite` assembly allows writing NUnit-based unit tests that execute on-device, and the `Mono.Android-Tests.csproj` project contains a number of such unit tests. The problem is that these unit tests aren't executed as part of the Jenkins build process, so there's no way to know if a given commit actually breaks anything. In short, the existence of those unit tests is meaningless. The task, then, is to fix the `make run-all-tests` target so that it runs on-device unit tests...on an Android device. Which raises all manner of problems. :-) (Hence 4+ months!) For starters, our internal tooling is a horrible mish-mash of make(1), ruby(1), bash(1), which creates an emulator, launches it, installs the test .apk onto the emulator, and runs the tests. I don't want all of that "cruft" in this repo, which means it needs to be rewritten in a form more amenable to this repo: MSBuild tasks....and some make(1). :-) Add a new `build-tools/scripts/UnitTestApks.targets` file, which will process an `@(UnitTestApk)` Item Group to permit deploying, running, and undeploying test .apks from an attached Android device. Add a slew of MSBuild tasks to support `@(UnitTestApk)`. Update the default `$(AndroidSupportedTargetJitAbis)` value to be `armeabi-v7a:x86`. The created Android emulator is x86.
jonpryorforce-pushed
the
jonp-run-tests
branch
from
November 21, 2016 20:34
78c0e9f to
9a15314Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do we want? Execution of unit tests!
When do we want it? Uh...4 months ago?
The
Xamarin.Android.NUnitLiteassembly allows writing NUnit-basedunit tests that execute on-device, and the
Mono.Android-Tests.csprojproject contains a number of such unit tests.
The problem is that these unit tests aren't executed as part of the
Jenkins build process, so there's no way to know if a given commit
actually breaks anything.
In short, the existence of those unit tests is meaningless.
The task, then, is to fix the
make run-all-teststarget so that itruns on-device unit tests...on an Android device.
Which raises all manner of problems. :-) (Hence 4+ months!)
For starters, our internal tooling is a horrible mish-mash of make(1),
ruby(1), bash(1), which creates an emulator, launches it, installs the
test .apk onto the emulator, and runs the tests. I don't want all of
that "cruft" in this repo, which means it needs to be rewritten in a
form more amenable to this repo: MSBuild tasks....and some make(1).
:-)
Add a new
build-tools/scripts/UnitTestApks.targetsfile, which willprocess an
@(UnitTestApk)Item Group to permit deploying, running,and undeploying test .apks from an attached Android device.
Add a slew of MSBuild tasks to support
@(UnitTestApk).Update the default
$(AndroidSupportedTargetJitAbis)value to bearmeabi-v7a:x86. The created Android emulator is x86.