Uh oh!
There was an error while loading. Please reload this page.
[NRefactory] Switch to Xamarin fork that contains SDK style csproj. - #5606
Merged
Conversation
jpobst
marked this pull request as ready for review
February 9, 2021 22:46
radekdoulik
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to target .NET 5/6 we need to build with
dotnet build, which requires SDK style projects.One set of
csprojfiles that need to be updated is NRefactory. The unit tests in Xamarin.Android use these assemblies along with the Mono debugging assemblies to ensure that changes do not break the ability to debug XA applications.The "official" NRefactory repository that we currently use has been archived. However, there already exists a Xamarin fork that the VSMac team uses. The relevant project files we need in that repo have been converted to SDK style, so we simply need to point our git submodule to that fork.