Uh oh!
There was an error while loading. Please reload this page.
[monodroid] Use MONO_AOT_MODE_INTERP_ONLY when available - #5635
Merged
Conversation
MemberAuthor
Haven't tried it yet. still need to read the documentation on how to run the changes locally. But it feels right. To test it, I would run this code: privatestaticstringOnInterp(){if(RuntimeFeature.IsDynamicCodeSupported){if(RuntimeFeature.IsDynamicCodeCompiled){return"JIT";}else{return"Interp";}}else{return"FullAOT";}} |
lambdageekforce-pushed
the
interp-fix
branch
2 times, most recently
from
March 2, 2021 20:56
8e50608 to
b5be8edCompareThis depends on a fix to mono/mono#18893 (make interp only mode distinct from MONO_AOT_MODE_LAST) which was done in mono/mono#20159 but only for .NET 6, not previous Mono releases. Fixesdotnet#5633
lambdageek
marked this pull request as ready for review
March 3, 2021 04:35
grendello
approved these changes
Mar 3, 2021
lambdageek
commented
Mar 3, 2021
MemberAuthor
The "MSBuild Emulator Tests MSBuild With Emulator - macOS - One .NET" lane is failing Not sure I understand what the "Smoke Tests APK Instrumentation - macOS" failure is saying. |
grendello
commented
Mar 3, 2021
Contributor
jonpryor
commented
Mar 3, 2021
Contributor
The crash in Smoke Tests > APK Instrumentation for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on a fix to mono/mono#18893 (make interp only mode distinct from
MONO_AOT_MODE_LAST) which was done in mono/mono#20159 but only for .NET 6, not previous Mono releases.Fixes#5633