Uh oh!
There was an error while loading. Please reload this page.
[Xamarin.Android.Build.Tasks] Use class-parse.exe out of MSBuild process - #6551
Merged
Conversation
jpobstforce-pushed
the
out-of-proc-class-parse
branch
3 times, most recently
from
December 8, 2021 02:51
89c9866 to
a02297eCompareUh oh!
There was an error while loading. Please reload this page.
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
Could you measure the build time before & after?
I think you could build a binding with -clp:performancesummary or -bl and just see how long this task takes.
| classPath.SaveXmlDescription (output); | ||
| var cmd = GetCommandLineBuilder (); | ||
| var responseFile = Path.Combine (Path.GetDirectoryName (OutputFile), "class-parse.rsp"); |
There was a problem hiding this comment.
If class-parse.exe succeeds, should we delete this file immediately? Just leave it on disk if there is a non-zero exit code?
Otherwise, should something delete it when you run the Clean target?
ContributorAuthor
There was a problem hiding this comment.
Good suggestions, added performance data and <FileWrites /> for response file.
jpobstforce-pushed
the
out-of-proc-class-parse
branch
from
December 13, 2021 21:37
a02297e to
7fdad64Comparejonathanpeppers
approved these changes
Dec 13, 2021
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
Looks good if CI ends up green 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop#499
There are potentially some conflicts with using
Xamarin.Android.Tools.Bytecodedirectly in the MSBuild process, as it now importsprotobuf-netwhich is a commonly used library.To ensure it isn't running in-process, switch our targets to shell out to
class-parse[.exe/.dll].Additionally add
class-parse.dll, etc. to the .NET 6 install pack. We are already shippingclass-parse.exe, etc. in the Classic installer even though it wasn't used, so no additional installer changes are needed there.As expected, moving this out-of-process is slightly slower, but still acceptable.
Additionally adds
java-resolution-report.logto<FileWrites />which was added in dotnet/java-interop#849.