Uh oh!
There was an error while loading. Please reload this page.
improve test performance measuring - #705
Conversation
jonpryor
commented
Jul 27, 2017
I love the idea. I have some ideas for the implementation. :-) |
| while ((line = reader.ReadLine ()) != null) { | ||
| int index = line.IndexOf (';'); | ||
| if (index < 1 || index == line.Length) |
There was a problem hiding this comment.
You should support comments within the file, and probably treat any line starting with # as a comment character.
| string line; | ||
| while ((line = reader.ReadLine ()) != null) { | ||
| int index = line.IndexOf (';'); |
There was a problem hiding this comment.
Why'd you choose ; as the separator? I'd think that (space) or = (equal) would make a bit more sense:
# current
last;monodroid-timing:\s+(?<message>.*)$
# vs one of
last monodroid-timing:\s+(?<message>.*)$
last=monodroid-timing:\s+(?<message>.*)$
I think I find the more readable, but the = has a nice connotation of "this is the key with an associated regex."
| int index = line.IndexOf (';'); | ||
| if (index < 1 || index == line.Length) | ||
| continue; | ||
| var label = line.Substring (0, index); |
There was a problem hiding this comment.
You should check that label is a non-empty string, if only for a better error message and sanity. :-)
There was a problem hiding this comment.
It already checks for it, if index < 1 then it skips to the next line
| Log.LogWarning ($"unable to create regex for label: {label} from pattern: {pattern}\n{e}"); | ||
| continue; | ||
| } | ||
| definedRegexs [line.Substring (0, index)] = regex; |
There was a problem hiding this comment.
This should instead be:
definedRegexs[label]=regex;There was a problem hiding this comment.
Additionally, is this wise or desirable? This allows overwriting previous labels, e.g. with a file of:
a;some-regex
a;another-regex
a;do we have enough duplicates yet?
Is it really a good idea for the "last" one to replace anything previously defined, without even a warning?
- measure JNIEnv.Initialize end - added timing definitions file parameter to the ProcessLogcatTiming task. It contains data series labels and regex patterns to match logcat lines with timestamp, separated by '=' character. see build-tools/scripts/TimingDefinitions.txt as an example. it can also contains comments, on the lines starting with '#' character if the pattern contains match named message, then the logger uses this match value instead of whole matched line (without timestamp)
be8c53e to
62a9debCompareFixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1193891 Changes: dotnet/java-interop@afbc5b3...ac914ce * dotnet/java-interop@ac914ce3: [ci] Add DevDiv required Roslyn analyzers, fix errors (#704) * dotnet/java-interop@a98c1ae1: [build] fix env vars causing gradle build error (#705) * dotnet/java-interop@75354b9f: [Java.Interop] Dispose, *then* Remove (#708) * dotnet/java-interop@8ea0bb28: [jnimarshalmethod-gen] Localizable errors (#696) Commit dotnet/java-interop@ac914ce3 moved the location of `NullableAttributes.cs`; update `Xamarin.Android.Tools.JavadocImporter.csproj` appropriately.
measure JNIEnv.Initialize end
added timing definitions file parameter to the ProcessLogcatTiming
task. It contains data series labels and regex patterns to match
logcat lines with timestamp, separated by semicolon. see
build-tools/scripts/TimingDefinitions.txt as an example.
if the pattern contains match named message, then the logger uses
this match value instead of whole matched line (without timestamp)