Uh oh!
There was an error while loading. Please reload this page.
bump linker to get fix for #57645 - #715
Merged
Merged
Conversation
- fixed by this commit: commit ee94279affccc16396cf97aac281e287515c866f Author: Radek Doulik <rodo@xamarin.com> Date: Fri Jul 28 16:28:12 2017 +0200 [linker] added workaround for invalid type forwards - fixes #57645 - ignore invalid forwards of nested types of exported forwarded types, which were added by a bug in csc. description by Marek Safar from https://bugzilla.xamarin.com/show_bug.cgi?id=57645#c13 Native csc (pre-Roslyn version) when encountered typeforwarded type it added automatically all its nested types including private/protected/internal ones. This bug was fixed in Roslyn csc but there are still many assemblies compiled with native csc (pre VS2015) which can have typeforwarded typeref to a type which is not available because it's not included in public API. - ignoring these forwarders here should be harmless, because if these types were used somewhere in the application, the linker would fail in the mark step, when trying to resolve the typereference to them - also added throwing the LoadException in case of missing non-nested forwarded exported types, instead of just crashing with System.NullReferenceException
radekdoulikforce-pushed
the
pr-bump-linker-fix-57645-d15-4
branch
from
August 3, 2017 15:35
1ff1130 to
f1755a3Comparejonpryor pushed a commit
that referenced
this pull request
Oct 20, 2020
Fixes: dotnet/java-interop#461Fixes: dotnet/java-interop#682Fixes: dotnet/java-interop#717Fixes: dotnet/java-interop#719Fixes: dotnet/java-interop#728 Changes: dotnet/java-interop@ac914ce...b991bb8 * dotnet/java-interop@b991bb86: [generator] Revert change to use auto-properties in EventArgs classes (#736) * dotnet/java-interop@ee50d89b: Bump to xamarin/xamarin-android-tools/master@f2af06f2 (#733) * dotnet/java-interop@a0b895c1: [build] Suppress NuGet warnings (#730) * dotnet/java-interop@8b1b0507: [generator] Fix parsing of complex generic types (#729) * dotnet/java-interop@ee7afeed: [generator] Prevent generating duplicate EventArgs classes (#726) * dotnet/java-interop@1f21f38c: [generator] Use GC.KeepAlive for reference type method parameters. (#725) * dotnet/java-interop@5136ef98: [Xamarin.Android.Tools.Bytecode] Hide Kotlin nested types inside (#723) * dotnet/java-interop@53d60513: [jnimarshalmethod-gen] Fix registration on Windows (#721) * dotnet/java-interop@5a834d42: [jnimarshalmethod-gen] Avoid creating AppDomains (#720) * dotnet/java-interop@a76edb8c: [Xamarin.Android.Tools.ApiXmlAdjuster] Find app.android.IntentService (#718) * dotnet/java-interop@6cde0877: [Java.Interop] Emit a reference assembly for Java.Interop.dll (#716) * dotnet/java-interop@b858dc59: [generator] Provide line/col numbers for api.xml warnings (#715) * dotnet/java-interop@9be92a04: [ci] Don't kick off CI for documentation only changes. (#712) * dotnet/java-interop@03c22722: [jnimarshalmethod-gen] Fix type resolution crash (#706)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed by this commit:
commit ee94279affccc16396cf97aac281e287515c866f
Author: Radek Doulik rodo@xamarin.com
Date: Fri Jul 28 16:28:12 2017 +0200