Uh oh!
There was an error while loading. Please reload this page.
[main] Update dependencies from dotnet/installer - #7217
Merged
jonathanpeppers merged 18 commits intoAug 8, 2022
Conversation
…220728.5 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22378.5 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestroBot
requested review from
jonathanpeppers, jonpryor and pjcollins
as code ownersJuly 28, 2022 22:20
…220729.2 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22379.2 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
…220731.2 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22381.2 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
Context: dotnet/sdk#26627 This is triggering a bug in the dotnet/sdk.
This reverts commit 9e5deba.
This reverts commit 9b533a3.
…220802.10 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22402.10 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
Member
This fails to build, must be something about the MSBuild argument parsing? The fact this prints ` characters, makes me think something is wrong here? |
jonathanpeppers
commented
Aug 3, 2022
Member
Ok, now we're at: So must have to do something to opt into binary formatter now. |
Context: https://github.com/dotnet/runtime/blob/197ae4c596553f7e6acb327ca2e31cc00c794c4d/src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatter.Core.cs#L11 Our build was failing with: src-ThirdParty/NUnitLite/Constraints/BinarySerializableConstraint.cs(57,17): error SYSLIB0011: 'BinaryFormatter.Serialize(Stream, object)' is obsolete: 'BinaryFormatter serialization is obsolete and should not be used. See https://aka.ms/binaryformatter for more information.' src-ThirdParty/NUnitLite/Constraints/BinarySerializableConstraint.cs(61,32): error SYSLIB0011: 'BinaryFormatter.Deserialize(Stream)' is obsolete: 'BinaryFormatter serialization is obsolete and should not be used. See https://aka.ms/binaryformatter for more information.' I can add the same `[Obsolete]` messages on `NUnit.Framework.Constraints.BinarySerializableConstraint` to solve this error.
Not Xamarin.Android
…220807.1 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22407.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
jonathanpeppers
approved these changes
Aug 8, 2022
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
The classic MSBuild test failed on provisionator, we probably don't need to rerun that one.
The designer tests failed with:
1) Invalid : D:/a/1/s/UITools/Designer/Xamarin.Designer.Android/Xamarin.AndroidDesigner.Tests/bin/Debug/Xamarin.AndroidDesigner.Tests.DLL
Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
----> Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
----> Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
----> Could not load file or assembly 'Microsoft.CodeAnalysis.Workspaces, Version=4.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
----> Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
----> Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
----> Could not load file or assembly 'Microsoft.CodeAnalysis.Workspaces, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
I assume this is unrelated, going to merge.
jonathanpeppers
deleted the
darc-main-d18a9e18-18a2-4332-93c3-a4f391da93a1
branch
August 8, 2022 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer