Uh oh!
There was an error while loading. Please reload this page.
[ci] Add support to net7.0 for multi-targeting in VS - #7311
Merged
Conversation
Context: xamarin/yaml-templates#180 Context: xamarin/yaml-templates#195 Context: xamarin/yaml-templates#199 Updates the build to use the latest MSI generation template. The v3 template uses the latest changes from arcade which include a large refactoring, support for multi-targeting, and support for workload pack group MSIs. The build will now produce two different VS Drop artifacts. The MSI and VSMAN files generated for SDK packs have been split out into a new `vsdrop-multitarget-signed` artifact, allowing us to include multiple versions of the SDK packs in VS. The `Microsoft.Android.Sdk` pack has been renamed to `Microsoft.Android.Sdk.net7` to allow it to be imported by the .NET 8 workload manifest when the time comes.
pjcollins
marked this pull request as ready for review
August 29, 2022 15:39
pjcollins
requested review from
dellis1972, jonathanpeppers and jonpryor
as code ownersAugust 29, 2022 15:39
jonathanpeppers
approved these changes
Aug 29, 2022
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
This looks good, if CI is green. It seems like the main NuGet.config might need the dotnet6 feed, we'll see.
pjcollins
commented
Aug 29, 2022
MemberAuthor
I think we can get away with only adding this to certain tests since it is already included in the workload install command used for test environment provisioning. There are some ILLink related failures on the latest run that seem interesting though, rerunning a couple of jobs to see if they pop up again... |
pjcollins
commented
Aug 30, 2022
MemberAuthor
Looks like the test job specific re-runs passed, I'm going to merge so we can get a build and we can look out for any repeat failures in main. |
pjcollins added a commit
that referenced
this pull request
Aug 30, 2022
Context: xamarin/yaml-templates#180 Context: xamarin/yaml-templates#195 Context: xamarin/yaml-templates#199 Updates the build to use the latest MSI generation template. The v3 template uses the latest changes from arcade which include a large refactoring, support for multi-targeting, and support for workload pack group MSIs. The build will now produce two different VS Drop artifacts. The MSI and VSMAN files generated for SDK packs have been split out into a new `vsdrop-multitarget-signed` artifact, allowing us to include multiple versions of the SDK packs in VS. The `Microsoft.Android.Sdk` pack has been renamed to `Microsoft.Android.Sdk.net7` to allow it to be imported by the .NET 8 workload manifest when the time comes.
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 31, 2022
* main: [ci] Split up signing for files to be notarized (dotnet#7321) [ci] Add support to net7.0 for multi-targeting in VS (dotnet#7311) [ci] Skip classic tests on .NET release branches (dotnet#7312) [tests] Use `$(AndroidSdkPlatformToolsVersion)`=33.0.3 (dotnet#7320) Bump to xamarin/java.interop/main@4f813cb2 (dotnet#7308) Bump to mono/mono.posix@d8994ca, dotnet/android-libzipsharp@98e9173 (dotnet#7309)
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 31, 2022
* mm-runtime: [ci] Split up signing for files to be notarized (dotnet#7321) [ci] Add support to net7.0 for multi-targeting in VS (dotnet#7311) [ci] Skip classic tests on .NET release branches (dotnet#7312) [tests] Use `$(AndroidSdkPlatformToolsVersion)`=33.0.3 (dotnet#7320) Bump to xamarin/java.interop/main@4f813cb2 (dotnet#7308) Bump to mono/mono.posix@d8994ca, dotnet/android-libzipsharp@98e9173 (dotnet#7309)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/yaml-templates/pull/180
Context: https://github.com/xamarin/yaml-templates/pull/195
Context: https://github.com/xamarin/yaml-templates/pull/199
Updates the build to use the latest MSI generation template. The v3
template uses the latest changes from arcade which include a large
refactoring, support for multi-targeting, and support for workload pack
group MSIs.
The build will now produce two different VS Drop artifacts. The MSI and
VSMAN files generated for SDK packs have been split out into a new
vsdrop-multitarget-signedartifact, allowing us to include multipleversions of the SDK packs in VS.
The
Microsoft.Android.Sdkpack has been renamed toMicrosoft.Android.Sdk.net7to allow it to be imported by the .NET 8workload manifest when the time comes.