Uh oh!
There was an error while loading. Please reload this page.
[main] Update dependencies from dotnet/installer - #7630
Merged
jonathanpeppers merged 4 commits intoDec 16, 2022
Conversation
…221211.1 Microsoft.Dotnet.Sdk.Internal From Version 8.0.100-alpha.1.22602.5 -> To Version 8.0.100-alpha.1.22611.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100 From Version 7.0.100-1.22564.1 -> To Version 8.0.100-1.22609.1 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestroBot
requested review from
jonathanpeppers, jonpryor and pjcollins
as code ownersDecember 12, 2022 13:32
Comment on lines
+40
to
48
| "lib/arm64-v8a/libmono-component-marshal-ilgen.so": { | ||
| "Size": 93552 | ||
| }, | ||
| "lib/arm64-v8a/libmonodroid.so": { | ||
| "Size": 434632 | ||
| "Size": 434704 | ||
| }, | ||
| "lib/arm64-v8a/libmonosgen-2.0.so": { | ||
| "Size": 3076080 | ||
| "Size": 3064488 | ||
| }, |
Member
There was a problem hiding this comment.
@naricc does libmono-component-marshal-ilgen.so look like the expected file size? Does it seem like libmonosgen-2.0.so should get smaller? We lost 11kb for one file, but gained 93kb in a new one?
There was a problem hiding this comment.
That looks like about the expected file size for libmono-component-marshal-ilgen.so. But I would expect the size of libmono-sgen-2.0.so to shrink more.
There was a problem hiding this comment.
@naricc should I file an issue in dotnet/runtime? It's not a large app size regression, but maybe someone should check we don't have duplicate methods in there or something.
There was a problem hiding this comment.
Yeah, file an issue, I will look into it.
Context: dotnet/linker#3124 (comment) Android projects are class libraries, and this current triggers: ILLink error IL1034: Root assembly 'MyAndroidApp, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' does not have entry point.
jonathanpeppers
approved these changes
Dec 16, 2022
jonathanpeppers
deleted the
darc-main-5ce75da7-0011-4d8b-af12-c8d7f2bb59e2
branch
December 16, 2022 21:58
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
Jan 4, 2023
* main: [Xamarin.Android.Build.Tasks] use %(TrimmerRootAssembly.RootMode) All (dotnet#7651) Bump to dotnet/installer@47a747f 8.0.100-alpha.1.22616.7 (dotnet#7647) Bump to dotnet/installer@167a4ed 8.0.100-alpha.1.22611.1 (dotnet#7630) Bump to xamarin/Java.Interop/main@f8d77fa (dotnet#7638) [ci] Fix Designer test paths (dotnet#7635) [Xamarin.Android.Build.Tasks] perf improvements for LlvmIrGenerator (dotnet#7626) [Xamarin.Android.Build.Tasks] AutoImport `*.webp` files (dotnet#7601) Localized file check-in by OneLocBuild Task (dotnet#7632) Bump $(ProductVersion) to 13.2.99 Bump to xamarin/monodroid/main@c0c933b7 (dotnet#7633) [Xamarin.Android.Build.Tasks] Fix aapt_rules.txt corruption (dotnet#7587) [Xamarin.Android.Build.Tasks] Add XA1031 error (dotnet#7448) Bump to xamarin/Java.Interop/main@149d70f (dotnet#7625) [CODEOWNERS] More updates to CODEOWNERS (dotnet#7628) [Xamarin.Android.Build.Tasks] avoid `File.Exists()` check (dotnet#7621)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer