Uh oh!
There was an error while loading. Please reload this page.
[Xamarin.Android.Build.Tasks] remove pdb2mdb - #7950
Merged
Merged
Conversation
Remove where we `ILRepack` `pdb2mdb.exe` into `Xamarin.Android.Build.Tasks.dll` and the `<ConvertDebuggingFiles/>` MSBuild task. These are not used in .NET 6+, and can be removed in xamarin-android/main. I also removed: * Code or tests around `.mdb` files * Tests around `DebugType=Full` In future PRs, I think we can remove: * `ILRepack` completely * `Xamarin.Android.Legacy.targets` * Other unused MSBuild tasks
jonathanpeppersforce-pushed
the
remove-pdb2mdb
branch
from
April 11, 2023 21:13
8c1cefc to
de8dba4Comparejonathanpeppers
marked this pull request as ready for review
April 12, 2023 17:12
jonathanpeppers
requested review from
dellis1972, grendello and jonpryor
as code ownersApril 12, 2023 17:12
dellis1972
commented
Apr 12, 2023
Contributor
ILRepack might need to stay since it stops us getting clashes with other IDE extensions which use Mono.Cecil and other dependencies. |
jonathanpeppers
commented
Apr 12, 2023
MemberAuthor
I think these were only used by Then these for Mono+MSBuild: But that is why I did 1 to start with, we can find out? |
jonpryor
commented
Apr 13, 2023
Contributor
IIRC that was only true for Xamarin Studio/Visual Studio for Mac, and not Visual Studio for Windows. |
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
Apr 14, 2023
* main: Bump to xamarin/Java.Interop/main@554d819 (dotnet#7951) [Microsoft.Android.Sdk.ILLink] fix crash when TZ changes (dotnet#7956) [tests] Port 'Xamarin.Android.JcwGen-Tests.JcwGen-Tests' to .NET (dotnet#7949) [Xamarin.Android.Build.Tasks] remove `pdb2mdb` (dotnet#7950) [ci] Add some extra params to configure the test templates (dotnet#7955) Convert `/tools` and `/build-tools` projects from `net472` to `$(DotNetStableTargetFramework)` (dotnet#7943) [Xamarin.Android.Build.Tasks] fix cases of missing `@(Reference)` (dotnet#7947) Bump com.android.tools:r8 from 4.0.52 to 8.0.40 (dotnet#7934) Bump to xamarin/Java.Interop/main@a172402 (dotnet#7944) [Xamarin.Android] Remove OpenTK, sqlite-xamarin, System.EnterpriseServices. (dotnet#7940) [ci] Stop building classic test suites. (dotnet#7938) Bumping to the correct monodroid commit Trying to bump monodroid to run debugger-tests Pass timeout to runtime
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
Apr 17, 2023
* main: Bump to xamarin/Java.Interop/main@554d819 (dotnet#7951) [Microsoft.Android.Sdk.ILLink] fix crash when TZ changes (dotnet#7956) [tests] Port 'Xamarin.Android.JcwGen-Tests.JcwGen-Tests' to .NET (dotnet#7949) [Xamarin.Android.Build.Tasks] remove `pdb2mdb` (dotnet#7950) [ci] Add some extra params to configure the test templates (dotnet#7955)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove where we
ILRepackpdb2mdb.exeintoXamarin.Android.Build.Tasks.dlland the<ConvertDebuggingFiles/>MSBuild task. These are not used in .NET 6+, and can be removed in xamarin-android/main.I also removed:
.mdbfilesDebugType=FullIn future PRs, I think we can remove:
ILRepackcompletelyXamarin.Android.Legacy.targets