Uh oh!
There was an error while loading. Please reload this page.
[Xamarin.Android.Build.Tasks] Add $(_BindingsToolsLocation) to allow overriding binding tool binaries. - #8069
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
…overriding binding tool binaries.
jonathanpeppers
approved these changes
May 25, 2023
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
The test failure seems to be caused by this being blank:
This seems unrelated, will investigate further, but we can merge this one.
jonathanpeppers pushed a commit
that referenced
this pull request
May 25, 2023
…overriding binding tool binaries. (#8069) There are a few instances where we would like to run a custom/updated `generator` and `class-parse` with an existing .NET install: * AndroidX/GPS would like newer fixes that may not have been backported to previous target frameworks that are still shipped * We would like some CI for `generator` itself that runs proposed changes against a large corpus like AndroidX/GPS before being committed to detect possible bugs sooner * Being able to easily test local `generator` changes against test cases without using `dotnet-local` (especially for running inside VS) To facilitate this, add the internal MSBuild option `$(_BindingsToolsLocation)` which can be set to a path where a custom/updated `generator`/`class-parse` exist: dotnet build MyBindings.csproj -p:_BindingsToolsLocation=C:\code\Java.Interop\bin\Debug\
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
May 26, 2023
* main: [Xamarin.Android.Build.Tasks] introduce Eol.targets for .NET 6 (dotnet#8047) [Xamarin.Android.Build.Tasks] Add $(_BindingsToolsLocation) to allow overriding binding tool binaries. (dotnet#8069) [tests] new test for provisioning JDKs (dotnet#8059) Localized file check-in by OneLocBuild Task (dotnet#8065) [AndroidDependenciesTests] Use platform-tools 34.0.3 (dotnet#8062) Bump to xamarin/Java.Interop/main@93c50fe (dotnet#8060) [Xamarin.Android.Build.Tasks] Update XA5300 text (dotnet#8057)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few instances where we would like to run a custom/updated
generatorandclass-parsewith an existing .NET install:generatoritself that runs proposed changes against a large corpus like AndroidX/GPS before being committed to detect possible bugs soonergeneratorchanges against test cases without usingdotnet-local(especially for running inside VS)To facilitate this, add the internal MSBuild option
$(_BindingsToolsLocation)which can be set to a path where a custom/updatedgenerator/class-parseexist: