Uh oh!
There was an error while loading. Please reload this page.
[tests] Remove XASdkDeployTests - #8139
Merged
Merged
Conversation
pjcollinsforce-pushed
the
xasdkdeploy-dupes
branch
from
June 21, 2023 15:59
b186891 to
e1c7775Comparepjcollins
marked this pull request as ready for review
June 21, 2023 17:52
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pjcollinsforce-pushed
the
xasdkdeploy-dupes
branch
from
June 21, 2023 19:09
e1c7775 to
6ae3b78CompareMost of our time intensive tests are in deploy and debug scenarios, and we have some duplication there that can be cleaned up. The `XASdkDeployTests` class has been removed, and non duplicated tests from this class have been moved into `InstallAndRunTests`. The `DotNetInstallAndRun` tests have been paired down to two tests for `net7.0-android` Debug and Release. The other permutations should be covered by existing install and run tests. The `DotNetDebug` tests have been removed, as they were effectively duplicates of `ApplicationRunsWithDebuggerAndBreaks`. The `Debugger` tests have had their connection settings adjusted to try fewer times to connect but wait longer in between attempts. We will now only wait for up to 5 minutes to connect rather than ~17 minutes.
pjcollinsforce-pushed
the
xasdkdeploy-dupes
branch
from
June 21, 2023 20:17
6ae3b78 to
0f87a89Comparejonathanpeppers
approved these changes
Jun 21, 2023
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
Jun 22, 2023
* main: [tests] Remove `XASdkDeployTests` (dotnet#8139)
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
Jun 22, 2023
* main: [tests] Remove `XASdkDeployTests` (dotnet#8139)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of our time intensive tests are in deploy and debug scenarios, and
we have some duplication there that can be cleaned up.
The
XASdkDeployTestsclass has been removed, and non duplicated testsfrom this class have been moved into
InstallAndRunTests.The
DotNetInstallAndRuntests have been paired down to two tests fornet7.0-androidDebug and Release. The other permutations should becovered by existing install and run tests.
The
DotNetDebugtests have been removed, as they were effectivelyduplicates of
ApplicationRunsWithDebuggerAndBreaks.The
Debuggertests have had their connection settings adjusted to tryfewer times to connect but wait longer in between attempts. We will now
only wait for up to 7 minutes to connect rather than ~17 minutes.