Skip to content

Clean up DotNetIgnore Unit Tests - #8163

Merged
dellis1972 merged 7 commits into
dotnet:mainfrom
dellis1972:dotnetignorecleanup
Jul 20, 2023
Merged

Clean up DotNetIgnore Unit Tests#8163
dellis1972 merged 7 commits into
dotnet:mainfrom
dellis1972:dotnetignorecleanup

Conversation

@dellis1972

@dellis1972dellis1972 commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

We have recently begun to remove suport for Xamarin.Android Classic.
Many of the Unit Tests labeled with the "DotNetIgnore" Category were flagged
as such because they did not work under .Net Android. This commit goes through
and removes tests which are not relevant in the .Net Android context. It also
modifies some of these tests which are relevant to work under .Net Android.

@dellis1972
dellis1972force-pushed the dotnetignorecleanup branch from 2a393d6 to fa7ff51CompareJuly 4, 2023 19:58
@dellis1972dellis1972 changed the title DotnetignorecleanupClean up DotNetIgnore Unit TestsJul 6, 2023
@dellis1972
dellis1972 marked this pull request as ready for review July 6, 2023 08:58
@dellis1972

Copy link
Copy Markdown
ContributorAuthor

Test failures are our good friend net_http_message_not_success_statuscode_reason

@dellis1972
dellis1972 requested review from pjcollins and removed request for jonpryorJuly 7, 2023 08:33

@pjcollinspjcollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits but LGTM, this will address most of #7777.

@dellis1972
dellis1972 merged commit 83bdddb into dotnet:mainJul 20, 2023
@dellis1972
dellis1972 deleted the dotnetignorecleanup branch July 20, 2023 13:28
grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 20, 2023
* main:
Bump to dotnet/installer@ca467d68c8 8.0.100-preview.7.23364.32 (dotnet#8176)
Clean up DotNetIgnore Unit Tests (dotnet#8163)
grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 24, 2023
* main:
$(AndroidPackVersionSuffix)=rc.1; net8 is 34.0.0-rc.1 (dotnet#8204)
Bump to dotnet/installer@ca467d68c8 8.0.100-preview.7.23364.32 (dotnet#8176)
Clean up DotNetIgnore Unit Tests (dotnet#8163)
[Xamarin.Android.Build.Tasks] fix duplicate `.aar` files (dotnet#8196)
[Documentation] Appease PoliCheck Rule: 79604 (dotnet#8197)
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dellis1972@jonathanpeppers@pjcollins