Skip to content

[build] don't pass $(RestoreAdditionalProjectSources) as a global property - #8380

Closed
jonathanpeppers wants to merge 2 commits into
dotnet:release/8.0.1xx-rc2from
jonathanpeppers:test-java-interop-import
Closed

[build] don't pass $(RestoreAdditionalProjectSources) as a global property#8380
jonathanpeppers wants to merge 2 commits into
dotnet:release/8.0.1xx-rc2from
jonathanpeppers:test-java-interop-import

Conversation

@jonathanpeppers

@jonathanpeppersjonathanpeppers commented Sep 27, 2023

Copy link
Copy Markdown
Member

This partially reverts 4c7b645.

Opening this to test how we can fix this with a change in java.interop.

Ran:

git checkout 4c7b6455b7bbf60268520e8d55996133210d1a37~1 build-tools\scripts\DotNet.targets

@jonathanpeppers
[build] don't pass $(RestoreAdditionalProjectSources) as a global p…
8a06bdd
…roperty
This partially reverts 4c7b645.
Opening this to test how we can fix this with a change in java.interop.
Ran:
git checkout 4c7b645~1 build-tools\scripts\DotNet.targets
@jonathanpeppersjonathanpeppers added the do-not-merge PR should not be merged. label Sep 27, 2023
@jonathanpeppersjonathanpeppers mentioned this pull request Sep 27, 2023
Merged
@jonathanpeppers

jonathanpeppers commented Sep 27, 2023

Copy link
Copy Markdown
MemberAuthor

Ok still broken:

Now will check if dotnet/java-interop#1148 fixes it.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

do-not-mergePR should not be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonathanpeppers