Uh oh!
There was an error while loading. Please reload this page.
Bump to xamarin/java.interop/main@ed63d890 - #8407
Merged
Merged
Conversation
jonathanpeppers
commented
Oct 10, 2023
MemberAuthor
The test passes now, but was failing before I bumped java.interop:
|
Changes: dotnet/java-interop@8e63cc8...ed63d89 * [generator] restore `[RegisterAttribute]` for *Implementor types
jonathanpeppersforce-pushed
the
java.interop-1149
branch
from
October 10, 2023 02:19
aaf3b55 to
3de1f7fComparejonathanpeppers
marked this pull request as ready for review
October 10, 2023 02:20
dellis1972
approved these changes
Oct 10, 2023
jonathanpeppers
commented
Oct 10, 2023
MemberAuthor
We've seen timeouts on other PRs, this one seems OK to merge. |
jonathanpeppers added a commit
that referenced
this pull request
Oct 10, 2023
Changes: dotnet/java-interop@8e63cc8...ed63d89 * [generator] restore `[RegisterAttribute]` for *Implementor types Other changes: * Added test to verify `Lmono/android/view/View_OnClickListenerImplementor;` exists after a build using `AndroidLinkMode=r8`. dotnet/java-interop#1149
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 11, 2023
* main: [Xamarin.Android.Build.Tasks] case-insensitive Legacy Designer fixup (dotnet#8376) [build] Update docs and remove `xabuild` mentions (dotnet#8406) Bump to xamarin/java.interop/main@ed63d890 (dotnet#8407)
jonathanpeppers added a commit
that referenced
this pull request
Oct 17, 2023
Changes: dotnet/java-interop@8e63cc8...ed63d89 * [generator] restore `[RegisterAttribute]` for *Implementor types Other changes: * Added test to verify `Lmono/android/view/View_OnClickListenerImplementor;` exists after a build using `AndroidLinkMode=r8`. dotnet/java-interop#1149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: dotnet/java-interop@8e63cc8...ed63d89
[RegisterAttribute]for *Implementor types