Uh oh!
There was an error while loading. Please reload this page.
[Refactor] Small refactoring to AddKeepAlives method - #8423
Merged
Conversation
jonathanpeppers
commented
Oct 13, 2023
Member
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
approved these changes
Oct 17, 2023
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
There is a ApplicationRunsWithDebuggerAndBreaks test failure, but that one is flaky and we can ignore.
grendello added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 18, 2023
* main: [Mono.Android] Generate API docs with "full" verbosity (dotnet#8435) [profiled-aot] update profile for .NET 8 GA (dotnet#8428) Bump to xamarin/Java.Interop/main@3c83179 (dotnet#8429) [Xamarin.Android.Build.Tasks] Small refactoring to `AddKeepAlives` method (dotnet#8423) [Xamarin.Android.Build.Tasks] Fixup indirect resource references (dotnet#8416)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
method.Parameters.Count == 0check should be faster than LINQ'sAnycall (CustomAttributes.Any). So moved it first.GetILProcessorwhich may allocate unnecessarily ifGC.KeepAlive(...)call was already found. It's not a big of problem though as it's not very common.