Skip to content

[build] Include ThirdPartyNotices in workload packs - #8455

Merged
pjcollins merged 3 commits into
dotnet:mainfrom
pjcollins:tpnotice
Oct 25, 2023
Merged

[build] Include ThirdPartyNotices in workload packs#8455
pjcollins merged 3 commits into
dotnet:mainfrom
pjcollins:tpnotice

Conversation

@pjcollins

@pjcollinspjcollins commented Oct 24, 2023

Copy link
Copy Markdown
Member

Adds the THIRD-PARTY-NOTICES.TXT file to all packs that contain a
license file.

Adds our `ThirdPartyNotices.txt` file to Microsoft.Android.Sdk.*.nupkg.
@pjcollins

Copy link
Copy Markdown
MemberAuthor

@jonpryor Looks like this works fine, do we want to include it in any other packs?

Archive: /Users/peter/Downloads/Microsoft.Android.Sdk.Darwin.34.99.0-ci.pr.gh8455.32.nupkg
Length Date Time Name
--------- ---------- ----- ----
518 10-24-2023 13:51 _rels/.rels
779 10-24-2023 13:51 Microsoft.Android.Sdk.Darwin.nuspec
22507 10-24-2023 17:36 LICENSE
...
244596 10-24-2023 17:42 ThirdPartyNotices.txt
150 10-24-2023 17:43 data/net8.0-android34/AndroidApiInfo.xml
4325 10-24-2023 13:52 [Content_Types].xml
--------- -------
281167360 381 files

@jonpryor

Copy link
Copy Markdown
Contributor

@pjcollins: should we call it THIRD-PARTY-NOTICES.TXT? That's what other packages appear to do:

% find ~/.nuget/packages/microsoft.* -iname THIRD-PARTY\*$HOME/.nuget/packages/microsoft.aspnetcore.app.ref/7.0.9/THIRD-PARTY-NOTICES.TXT
…
$HOME/.nuget/packages/microsoft.netcore.app.host.osx-x64/7.0.9/THIRD-PARTY-NOTICES.TXT
…
# 689 total

@jonpryor

Copy link
Copy Markdown
Contributor

@pjcollinsasked:

do we want to include it in any other packs?

I think it should go into any workload pack that redistributes 3rd party code, which might very well be all of them? Certainly Microsoft.Android.Sdk.Darwin and Microsoft.Android.Sdk.Windows.

@pjcollins

pjcollins commented Oct 24, 2023

Copy link
Copy Markdown
MemberAuthor

@pjcollinsasked:

do we want to include it in any other packs?

I think it should go into any workload pack that redistributes 3rd party code, which might very well be all of them? Certainly Microsoft.Android.Sdk.Darwin and Microsoft.Android.Sdk.Windows.

At a glance the Ref/Runtime packs only appear to contain our content, so I think the inclusion in the only the SDK packs should be sufficient.

edit: On second thought, if we are mentioning build dependencies in there maybe it should go into all three pack types...

@pjcollinspjcollins changed the title [build] Include ThirdPartyNotices.txt in the SDK nupkg[build] Include ThirdPartyNotices.txt in workload packsOct 24, 2023
@pjcollinspjcollins changed the title [build] Include ThirdPartyNotices.txt in workload packs[build] Include ThirdPartyNotices in workload packsOct 24, 2023
@pjcollins
pjcollins merged commit 2081a20 into dotnet:mainOct 25, 2023
@pjcollins
pjcollins deleted the tpnotice branch October 25, 2023 15:59
grendello added a commit that referenced this pull request Oct 30, 2023
* main:
Localized file check-in by OneLocBuild Task (#8462)
[build] Do not install build-tools 30.0.3 (#8461)
[build] Include ThirdPartyNotices in workload packs (#8455)
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pjcollins@jonpryor@grendello