Uh oh!
There was an error while loading. Please reload this page.
[Xamarin.Android.Build.Tasks] Crash when using NetStandard and Xamarin.Forms - #850
Merged
Conversation
jonpryor
commented
Sep 13, 2017
Contributor
This should add a "test" to ensure that this fix works. See also: Commit: 0809427 Perhaps the test should simply be adding |
dellis1972
commented
Sep 13, 2017
ContributorAuthor
dellis1972
commented
Sep 13, 2017
ContributorAuthor
build |
Merged
dellis1972
commented
Sep 14, 2017
ContributorAuthor
Tests are in #846 |
dellis1972
commented
Sep 14, 2017
ContributorAuthor
build |
dellis1972
commented
Sep 15, 2017
ContributorAuthor
@jonpryor the APk Tests failing here seem to be SSL related and TimeZone related.. not sure they would be caused by this PR though. So I have no idea why they are happening.. |
dellis1972
commented
Sep 15, 2017
ContributorAuthor
build |
dellis1972
commented
Sep 15, 2017
ContributorAuthor
Might be the Locale tests |
…n.Forms Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=57342 Commit 8f2ae24 attempted to fix this issue. However it made the assumption that `@(ReferenceCopyLocalPaths)` contained the same items as `@(ReferencePath)`. However it did not. So we should use a combination of the two to figure out what assmeblies are needed. We need to disgard reference assemblies though, we do this by checking for the appropriate attributes before we add the assembly to the list of items we want to package.
dellis1972
commented
Sep 15, 2017
ContributorAuthor
@jonpryor fixed :) |
dellis1972 added a commit
that referenced
this pull request
Oct 6, 2017
…n.Forms (#850) Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=57342 Commit 8f2ae24 attempted to fix this issue. However it made the assumption that `@(ReferenceCopyLocalPaths)` contained the same items as `@(ReferencePath)`. However it did not. So we should use a combination of the two to figure out what assmeblies are needed. We need to disgard reference assemblies though, we do this by checking for the appropriate attributes before we add the assembly to the list of items we want to package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=57342
Commit 8f2ae24 attempted to fix this issue. However it made the
assumption that
@(ReferenceCopyLocalPaths)contained the sameitems as
@(ReferencePath). However it did not. So we should usea combination of the two to figure out what assmeblies are needed.
We need to disgard reference assemblies though, we do this by
checking for the appropriate attributes before we add the assembly
to the list of items we want to package.