Uh oh!
There was an error while loading. Please reload this page.
[xaprepare] use $(XAPackagesDir) for NuGet folder - #8613
Merged
Conversation
After returning from the holidays, xamarin-android failed to build (`-t:Prepare`) with: Step Xamarin.Android.Prepare.Step_InstallDotNetPreview failed: 7zip executable 'D:\7-zip.commandline\18.1.0\tools\x64\7za.exe' not found System.InvalidOperationException: Step Xamarin.Android.Prepare.Step_InstallDotNetPreview failed: 7zip executable 'D:\7-zip.commandline\18.1.0\tools\x64\7za.exe' not found ---> System.InvalidOperationException: 7zip executable 'D:\7-zip.commandline\18.1.0\tools\x64\7za.exe' not found at Xamarin.Android.Prepare.ToolRunner..ctor(Context context, Log log, String toolPath) in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\ToolRunners\ToolRunner.cs:line 57 at Xamarin.Android.Prepare.SevenZipRunner..ctor(Context context, Log log, String toolPath) in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\ToolRunners\SevenZipRunner.cs:line 19 at Xamarin.Android.Prepare.Utilities.Unpack(String fullArchivePath, String destinationDirectory, Boolean cleanDestinatioBeforeUnpacking) in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\Application\Utilities.cs:line 142 at Xamarin.Android.Prepare.Step_InstallDotNetPreview.InstallDotNetAsync(Context context, String dotnetPath, String version, Boolean runtimeOnly) in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\Steps\Step_InstallDotNetPreview.cs:line 250 at Xamarin.Android.Prepare.Step_InstallDotNetPreview.Execute(Context context) in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\Steps\Step_InstallDotNetPreview.cs:line 24 at Xamarin.Android.Prepare.Step.Run(Context context) in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\Application\Step.cs:line 42 at Xamarin.Android.Prepare.Scenario.Run(Context context, Log log) in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\Application\Scenario.cs:line 37 --- End of inner exception stack trace --- at Xamarin.Android.Prepare.Scenario.Run(Context context, Log log) in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\Application\Scenario.cs:line 48 at Xamarin.Android.Prepare.Context.Execute() in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\Application\Context.cs:line 511 at Xamarin.Android.Prepare.App.Run(String[] args) in D:\src\xamarin-android\build-tools\xaprepare\xaprepare\Main.cs:line 162 I am using `%NUGET_PACKAGES%` on my local machine to point to a DevDrive at `D:\.nuget\packages\`, for some reason this is breaking the build? Previously we were using logic such as: return Path.GetFullPath ( Path.Combine ( ctx.Properties.GetRequiredValue (KnownProperties.PkgXamarin_LibZipSharp), "..", ".." ) ); Instead of using `$(PkgXamarin_LibZipSharp)`, let's use `$(XAPackagesDir)` as logic in `Configuration.props` was added in 66a0389 to consider `%NUGET_PACKAGES%`.
pjcollins
approved these changes
Jan 3, 2024
grendello added a commit
that referenced
this pull request
Jan 8, 2024
* main: [tests] fix `MAUI Integration` lane (#8614) [xaprepare] use `$(XAPackagesDir)` for NuGet folder (#8613) Add ApiScan to nightly build (#8605) Bump to dotnet/installer@29db8a1157 9.0.100-alpha.1.23628.5 (#8611) [Mono.Android] Fix ServerCertificateCustomValidator (#8594) Bump to dotnet/installer@e08874da58 9.0.100-alpha.1.23625.1 Bump to dotnet/installer@fae23c6571 9.0.100-alpha.1.23618.2 Localized file check-in by OneLocBuild Task (#8589) [tests] enable Xamarin.Android.LibraryProjectZip-LibBinding test (#8588)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After returning from the holidays, xamarin-android failed to build (
-t:Prepare) with:I am using
%NUGET_PACKAGES%on my local machine to point to a DevDrive atD:\.nuget\packages\, for some reason this is breaking the build?Previously we were using logic such as:
Instead of using
$(PkgXamarin_LibZipSharp), let's use$(XAPackagesDir)as logic inConfiguration.propswas added in 66a0389 to consider%NUGET_PACKAGES%.