[xamarin-android-tools] import $(LibZipSharpVersion) value

[jonathanpeppers]

Somewhere in the dotnet/maui repo, it encountered the error:

XARLP7028
System.IO.FileNotFoundException: Could not load file or assembly 'libZipSharp, Version=3.0.0.0, Culture=neutral, PublicKeyToken=276db85bc4e20efc' or one of its dependencies. The system cannot find the file specified.File name: 'libZipSharp, Version=3.0.0.0, Culture=neutral, PublicKeyToken=276db85bc4e20efc' at Xamarin.Android.Tasks.ResolveLibraryProjectImports.Extract(IDictionary`2 jars, ICollection`1 resolvedResourceDirectories, ICollection`1 resolvedAssetDirectories, ICollection`1 resolvedEnvironments, ICollection`1 proguardConfigFiles) at Xamarin.Android.Tasks.ResolveLibraryProjectImports.RunTask() at Microsoft.Android.Build.Tasks.AndroidTask.Execute() in /Users/runner/work/1/s/xamarin-android/external/xamarin-android-tools/src/Microsoft.Android.Build.BaseTasks/AndroidTask.cs:line 25WRN: Assembly binding logging is turned OFF.To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.Note: There is some performance penalty associated with assembly bind failure logging.To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].
Graphics (Graphics\src\Graphics)
C:\repos\dotnet\maui\bin\dotnet\packs\Microsoft.Android.Sdk.Windows\34.99.0-preview.2.171\tools\Xamarin.Android.EmbeddedResource.targets

(don't have a link)

If I download our build from main, I see that
Microsoft.Android.Build.BaseTasks.dll references the 3.0.0.0 version of libZipSharp, while the other MSBuild task assemblies reference the newer one.

We override $(LibZipSharpVersion) in Directory.Build.props, but this value doesn't make it inside the external/xamarin-android-tools submodule. Import Directory.Build.props from the submodule's *.override.props file.

[dellis1972]

do we need to change XAT to pull in this file? Looking at the Directory.Build.props in XAT i looks for this in the root of its checkout.
Also do we need /want to pull in everything from the xa Directory.Build.props?

[jonathanpeppers]

do we need to change XAT to pull in this file? Looking at the Directory.Build.props in XAT i looks for this in the root of its checkout.

It should work, because I've had to use it on some of our servicing branches:

https://github.com/xamarin/xamarin-android/blob/release/8.0.1xx/external/xamarin-android-tools.override.props

Also do we need /want to pull in everything from the xa Directory.Build.props?

I might move just the NuGet package versions to a new file -- let's see if it works.

[jonathanpeppers]

This appears to work, if I open tools\Microsoft.Android.Build.BaseTasks.dll in ILSpy, it has a Reference:

// libZipSharp, Version=3.1.1.0, Culture=neutral, PublicKeyToken=276db85bc4e20efc (unresolved)

While the old one had:

// libZipSharp, Version=3.0.0.0, Culture=neutral, PublicKeyToken=276db85bc4e20efc (unresolved)

[jonpryor]

Fixes: https://github.com/dotnet/maui/issues/20752
Context: d1ba2ccdd1377677a6dd24dc13c7a23fd1b8b930
Context: https://github.com/xamarin/xamarin-android-tools/commit/34e98e2b65917d105169f868b5648f67e68b6784
Context: https://github.com/xamarin/xamarin-android/pull/8746`dotnet build` (.NET Core) ignores assembly versions.
`msbuild.exe` (.NET Framework) does not.
Enter d1ba2ccd, which updates the `libZipSharp.dll` assembly version
from 3.0.0.0 to 3.1.1.0. However, this change only impacted
`Xamarin.Android.Build.Tasks.dll`:
% monodis --assemblyref bin/Release/lib/packs/Microsoft.Android.Sdk.Darwin/34.99.0/tools/Xamarin.Android.Build.Tasks.dll…11: Version=3.1.1.0	Name=libZipSharp	Flags=0x00000000
It did *not* impact `Microsoft.Android.Build.BaseTasks.dll`, as it
is built by `external/xamarin-android-tools` and was using a
`@(PackageReference)` for libZipSharp 3.0.0:
% monodis --assemblyref bin/Release/lib/packs/Microsoft.Android.Sdk.Darwin/34.99.0/tools/Microsoft.Android.Build.BaseTasks.dll…5: Version=3.0.0.0 Name=libZipSharp Flags=0x00000000
The resulting NuGet package only contains *one*`libZipSharp.dll`,
the 3.1.1.0 version (what `Xamarin.Android.Build.Tasks.dll` refs).
On PR builds and CI, everything was fine, because all the tests we
have use `dotnet build`, and .NET Core ignores assembly versions.
However, if you use *`msbuild.exe`* to invoke the tasks within
`Microsoft.Android.Build.BaseTasks.dll`, things fail:
XARLP7028 System.IO.FileNotFoundException: Could not load file or assembly 'libZipSharp, Version=3.0.0.0, Culture=neutral, PublicKeyToken=276db85bc4e20efc' or one of its dependencies.The system cannot find the file specified.File name: 'libZipSharp, Version=3.0.0.0, Culture=neutral, PublicKeyToken=276db85bc4e20efc' at Xamarin.Android.Tasks.ResolveLibraryProjectImports.Extract(IDictionary`2 jars, ICollection`1 resolvedResourceDirectories, ICollection`1 resolvedAssetDirectories, ICollection`1 resolvedEnvironments, ICollection`1 proguardConfigFiles) at Xamarin.Android.Tasks.ResolveLibraryProjectImports.RunTask() at Microsoft.Android.Build.Tasks.AndroidTask.Execute() in /Users/runner/work/1/s/xamarin-android/external/xamarin-android-tools/src/Microsoft.Android.Build.BaseTasks/AndroidTask.cs:line 25
Fix this by adding an `external/xamarin-android-tools.override.props`
file (xamarin/xamarin-android-tools@34e98e2b) which imports
`Directory.Build.props`, which causes `$(LibZipSharpVersion)` to be
set so that the xamarin-android-tools build uses values provided by
xamarin-android.
TODO: xamarin/xamarin-android#8746 adds a unit test for the
"build with `msbuild.exe`" scenario.